GNOME Bugzilla – Bug 627134
photography interface: add API for capture correction
Last modified: 2010-11-01 17:57:13 UTC
Created attachment 168058 [details] photography extenstion patch for capture correction features Current gstreamer photography interface supports a limited image capture setting. Some features such as noise reduction, red eye reduction are available in some digital camera device and will be supported by the ISP on Intel Atom platforms. These features aren't supported by photography interface. The patch in the attachment will add following features control to photography interface. GST_PHOTOGRAPHY_CAPTURE_CORRECTION_GDC: Geometry Distortion Correction GST_PHOTOGRAPHY_CAPTURE_CORRECTION_RER: Red Eye Reduction GST_PHOTOGRAPHY_CAPTURE_CORRECTION_CAC: Chromatic Aberration Correction GST_PHOTOGRAPHY_CAPTURE_CORRECTION_EE: Edge Enhancement, increates the sharpness of the image GST_PHOTOGRAPHY_CAPTURE_CORRECTION_FCC: False Color Correction GST_PHOTOGRAPHY_CAPTURE_CORRECTION_DPC: Defect Pixel Correction GST_PHOTOGRAPHY_CAPTURE_CORRECTION_SC: Shading Correction GST_PHOTOGRAPHY_CAPTURE_CORRECTION_BLC: Black Level Compensation GST_PHOTOGRAPHY_CAPTURE_CORRECTION_IMAGE_STABLE: Still Image Stabilization GST_PHOTOGRAPHY_CAPTURE_CORRECTION_VIDEO_STABLE: Video Stabilization The corresponding control ID are also planned to add to the V4L2 control IDs.
Created attachment 171074 [details] [review] image and video capture correction extention to photography interface
The reason why we don't expose these: GST_PHOTOGRAPHY_CAPTURE_CORRECTION_GDC: Geometry Distortion Correction GST_PHOTOGRAPHY_CAPTURE_CORRECTION_CAC: Chromatic Aberration Correction GST_PHOTOGRAPHY_CAPTURE_CORRECTION_FCC: False Color Correction GST_PHOTOGRAPHY_CAPTURE_CORRECTION_DPC: Defect Pixel Correction GST_PHOTOGRAPHY_CAPTURE_CORRECTION_SC: Shading Correction GST_PHOTOGRAPHY_CAPTURE_CORRECTION_BLC: Black Level Compensation is that those should just always be enabled. The reason that we don't expose these: GST_PHOTOGRAPHY_CAPTURE_CORRECTION_RER: Red Eye Reduction GST_PHOTOGRAPHY_CAPTURE_CORRECTION_EE: Edge Enhancement, increates the sharpness of the image GST_PHOTOGRAPHY_CAPTURE_CORRECTION_IMAGE_STABLE: Still Image Stabilization GST_PHOTOGRAPHY_CAPTURE_CORRECTION_VIDEO_STABLE: Video Stabilization are that those are best done as separate plugins. Ideally even NoiseReduction would be a separate plugin.
1. GST_PHOTOGRAPHY_CAPTURE_CORRECTION_FCC: False Color Correction 2. GST_PHOTOGRAPHY_CAPTURE_CORRECTION_DPC: Defect Pixel Correction 3. GST_PHOTOGRAPHY_CAPTURE_CORRECTION_BLC: Black Level Compensation These are always enabled. I can delete it from the photography interface. 4. GST_PHOTOGRAPHY_CAPTURE_CORRECTION_VIDEO_STABLE: Video Stabilization 5. GST_PHOTOGRAPHY_CAPTURE_CORRECTION_GDC: Geometry Distortion Correction 6. GST_PHOTOGRAPHY_CAPTURE_CORRECTION_CAC: Chromatic Aberration Correction These three features are OFF be default. If it is turn on, it will impact the performance. 7. GST_PHOTOGRAPHY_CAPTURE_CORRECTION_EE: Edge Enhancement, increates the sharpness of the image 8. GST_PHOTOGRAPHY_CAPTURE_CORRECTION_SC: Shading Correction These two features are ON be default. User need to turn it off through photography interface. 4,5,6,7,8 are the ISP features. It is done in the ISP pipeline. We propose to add it to the phtography interface. For the red eye reduction and still image stablization, they are postprocessing and we think we can do it in the camera source element and export it as the camera source property.
Yes, please remove 1-3. Why might want to add Video/Image stabilisation to photography interface as some cameras might even have optical one. But then the optical one is something that one would not turn off. Please add GST_PHOTOGRAPHY_CAPTURE_CORRECTION_GDC GST_PHOTOGRAPHY_CAPTURE_CORRECTION_CAC GST_PHOTOGRAPHY_CAPTURE_CORRECTION_EE GST_PHOTOGRAPHY_CAPTURE_CORRECTION_SC to your camerasrc as boolean flags for now. I can only repeat, that we can't stabilize the photo iface if we constantly add things. We need to aim for keeping post-processing as separate effects.
It sound reasonable to stabilize the photo iface. Add these features to the camerasrc as boolean flags.
Did you mean to mark the bug as RESOLVED FIXED?
Yes. The photograhy don't need to update. I can add this extension to the camerasrc element.