After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 627070 - Poppler.Action[...] are classes, but should be structs
Poppler.Action[...] are classes, but should be structs
Status: RESOLVED FIXED
Product: vala
Classification: Core
Component: Bindings
0.9.x
Other Linux
: Normal normal
: ---
Assigned To: Vala maintainers
Vala maintainers
Depends on:
Blocks:
 
 
Reported: 2010-08-16 17:47 UTC by Rumen Zarev
Modified: 2010-08-17 09:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch fix metadata for vapi generation (682 bytes, patch)
2010-08-16 17:47 UTC, Rumen Zarev 		committed Details | Review

Description Rumen Zarev 2010-08-16 17:47:33 UTC 
Created attachment 167984 [details] [review]
Patch fix metadata for vapi generation

Poppler.Action is a union of structs Poppler.ActionAny, Poppler.ActionGotoDest, etc. The current binding makes them classes which generates wrong C code. Added a patch fixing poppler-glib.metadata to make them structs.
Comment 1 Luca Bruno 2010-08-17 09:09:03 UTC 
Review of attachment 167984 [details] [review]:

commit 1fdea31e0cc491c2afdd5b312360a410b859fb27
Author: Rumen Zarev <rumen.coding@gmail.com>
Date:   Tue Aug 17 11:02:43 2010 +0200

    poppler-glib: Make PopplerAction* be structs without type id.
    
    Fixes bug 627070.

Thanks for your patch, I've added has_type_id="0" because those structs aren't registered in the glib type system.