GNOME Bugzilla – Bug 626875
Fix handling of --composite and --no-composite command line options
Last modified: 2011-01-04 16:56:20 UTC
Created attachment 167834 [details] [review] [RFQ] Fix --no-composite and --composite cli options Currently these two command line options just set the corresponding GConf key, but they don't actually take immediate effect. This is, as I see it, not the desired effect. It is also questionable whether the desired effect is to set the GConf key in the first place, and hence affect subsequent sessions, or to just make the setting a one-time thing. This patch at least takes care of the first problem. In addition, quite a lot of clutter initialization takes place before these two command line options are even looked at. If compositing is to be disabled, would it not make sense to completely skip clutter initialization? Proposed patch attached.
sorry for the extra noise, but I (feeling stupidly) take back the comment about clutter initialization. The 'initialization' is minimal and probably not worth looking at...
Does Mutter work non-composited? We haven't tested that for a very long time and it would sort of surprise me if it did without more work. Then we have to decide if we *want* it to work. My opinion is basically no - we chose to fork Mutter off from Metacity so we could change stuff and rely on compositing. If we are trying to make Mutter do everything that Metacity does and more, than there was no point in the fork. [ And we already removed reduced_resources_mode so Mutter doesn't work as a drop-in replacement for Metacity. ] If Tomas is in agreement with that line of thinking, I'd say that the only patches we'd want here are patches to remove the command line options and GConf keys.
That's a good point. I was under the impression that Mutter was to be a replacement for Metacity, in which case this patch would make sense. If that's /not/ the case, then yes, removing the no-composite mode would make the most sense. It does, however, work in that mode just fine. I've been using Mutter as a wm for gnome (not gnome-shell) for a while now, and turning off compositing has been desirable for me when I want to run openGL intensive apps. If the decision is to remove --no-composite, I'd be happy to submit the appropriate patch, unless you or someone else wants to take care of it.
Created attachment 168119 [details] [review] Remove ability to turn compositing off in mutter If the decision is made to remove the no-composite feature, here is a proposed patch to do so. Thoughts?
Review of attachment 168119 [details] [review]: Patch looks good to me. I'd like to get feedback from Tomas before we land this.
*ping* Tomas, it looks like this one depends on you you ;)
Patch rebased to current master and pushed.