After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 626870 - Updates for Gtk3
Updates for Gtk3
Status: RESOLVED FIXED
Product: gnome-control-center
Classification: Core
Component: general
unspecified
Other All
: Normal normal
: ---
Assigned To: Control-Center Maintainers
Control-Center Maintainers
Depends on:
Blocks: 626688
 
 
Reported: 2010-08-13 19:23 UTC by Benjamin Otte (Company)
Modified: 2010-08-21 02:08 UTC
See Also:
GNOME target: 3.0
GNOME version: ---

Attachments
Replace Gdk drawing with Cairo (9.40 KB, patch)
2010-08-13 19:23 UTC, Benjamin Otte (Company) 		committed Details | Review
typing-break: use gtk API to determine label layout location (2.26 KB, patch)
2010-08-13 19:23 UTC, Benjamin Otte (Company) 		committed Details | Review
removes dependency on gdk get background (not available anymore) (3.60 KB, patch)
2010-08-17 22:56 UTC, Alban Browaeys 		none Details | Review
display: Copy background setter code from mutter (2.23 KB, patch)
2010-08-21 02:07 UTC, Benjamin Otte (Company) 		committed Details | Review

Description Benjamin Otte (Company) 2010-08-13 19:23:22 UTC 
The following two patches fix gnome-control-center to work with recent Gtk3, taking care of the Cairo conversion and changes to GtkLabel layout code. They should also work fine with Gtk2.
Comment 1 Benjamin Otte (Company) 2010-08-13 19:23:24 UTC 
Created attachment 167830 [details] [review]
Replace Gdk drawing with Cairo
Comment 2 Benjamin Otte (Company) 2010-08-13 19:23:27 UTC 
Created attachment 167831 [details] [review]
typing-break: use gtk API to determine label layout location

The previous code tried to imitate GtkLabel, but failed to account for
changes to its API. The new code uses gtk_label_get_layout_offsets()
which is exactly doing the same thing, but compatibly.
Comment 3 Alban Browaeys 2010-08-17 22:56:50 UTC 
Created attachment 168152 [details] [review]
removes dependency on gdk get background (not available anymore)

With current gdk it fails to build otherwise.
Comment 4 Benjamin Otte (Company) 2010-08-20 01:22:46 UTC 
The background code should look something like this:
http://git.gnome.org/browse/mutter/tree/src/ui/frames.c?id=0839c100c08932fdedacb7ceb43783431d5d3b6c#n2046
Comment 5 Benjamin Otte (Company) 2010-08-21 02:07:24 UTC 
Created attachment 168443 [details] [review]
display: Copy background setter code from mutter

This code uses the new GDK API to set the window background.
Comment 6 Benjamin Otte (Company) 2010-08-21 02:08:19 UTC 
Committed the 3 patches after review with Thomas.