GNOME Bugzilla – Bug 626728
Add EmpathyIndividualWidget
Last modified: 2010-08-19 18:23:09 UTC
Created attachment 167725 [details] [review] Squashed diff of the individual-widget branch This branch adds an EmpathyIndividualWidget, and changes the Information dialogue and EmpathyIndividualView tooltips to use it. http://git.collabora.co.uk/?p=user/pwith/empathy;a=shortlog;h=refs/heads/individual-widget It isn't finished yet; notably, only the location of one of the Individual's Personas is shown (even though the location of all applicable Personas could easily be shown as separate markers on the map). Querying Telepathy for contact details commonly causes crashes at the moment, and hasn't been reworked to use multiple Personas yet. This doesn't affect the Information dialogue or contact list tooltips, though. In terms of appearance, it's finished, so could be committed before the UI freeze on Monday, and then the code cleaned up later. Alternatively, we could give the release team ice cream and ask them if we could commit it after Monday, once the code's had some more love and stability.
(In reply to comment #0) > It isn't finished yet; ... By this, I mean that the code isn't clean and tidy, and it is probably not handling some signals which it should, but from some quick testing it works in the contact list tooltip and Information dialogue cases, so could be considered for committing before the UI freeze. In any case, it needs lots of code cleanup, which I'll do next week.
I'd prefer to review/merge something more polished rather than rushing and introducing even more regressions than we already have. I wouldn't worry too much about the UI freeze, if we get things done next week that shouldn't be an issue.
I thought you might say that. ;-) I'll continue working on it on Monday then.
Branch ready for review, based on master: http://git.collabora.co.uk/?p=user/pwith/empathy;a=shortlog;h=refs/heads/individual-widget-rebase2
Created attachment 168285 [details] [review] Squashed diff of the individual-widget-rebase2 branch
Created attachment 168301 [details] Backtrace of group-adding segfault I hit this segfault when adding an Individual to a group in this branch. It didn't matter if the Individual had 1 or 2 personas (both cause the crash consistently).
Review of attachment 168285 [details] [review]: Other than the crasher backtrace attached to this bug, I brought up a number of issues in IRC. So this patch needs a little work.
Created attachment 168307 [details] [review] Squashed diff of the individual-widget-rebase3 branch All fixed. http://git.collabora.co.uk/?p=user/pwith/empathy;a=shortlog;h=refs/heads/individual-widget-rebase3
Reviewed and OKed over IRC by Travis. Committed. commit b992a04452d574d1afb5787499ee0498b74210d3 Author: Philip Withnall <philip.withnall@collabora.co.uk> Date: Mon Jul 5 17:09:35 2010 +0100 Use EmpathyIndividualWidget in EmpathyIndividualInformationDialog .../empathy-individual-information-dialog.c | 38 +++++-------------- 1 files changed, 10 insertions(+), 28 deletions(-) commit 4c6aa4d6c9ffa412fa0cf1513dab34af6aedc7e9 Author: Philip Withnall <philip.withnall@collabora.co.uk> Date: Wed Aug 11 18:51:28 2010 +0100 Use EmpathyIndividualWidget in EmpathyIndividualView tooltips libempathy-gtk/empathy-individual-view.c | 20 ++++++++------------ 1 files changed, 8 insertions(+), 12 deletions(-) commit b733c20124b92b6dedec267eee6b586b312e5d5b Author: Philip Withnall <philip.withnall@collabora.co.uk> Date: Thu Aug 19 13:03:56 2010 +0100 Fix the flags given to the widget in EmpathyIndividualLinker libempathy-gtk/empathy-individual-linker.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) commit 48417775ef19cdb1ebe2ecd631953f431aa144b4 Author: Philip Withnall <philip.withnall@collabora.co.uk> Date: Thu Aug 19 13:05:36 2010 +0100 Expand EmpathyIndividualWidget It's now a fully-fledged widget of its own, rather than a thin wrapper around EmpathyContactWidget. Closes: bgo#626728 libempathy-gtk/Makefile.am | 3 +- libempathy-gtk/empathy-individual-widget.c | 1892 +++++++++++++++++++++++++-- libempathy-gtk/empathy-individual-widget.h | 42 +- libempathy-gtk/empathy-individual-widget.ui | 173 +++ po/POTFILES.in | 2 + 5 files changed, 2012 insertions(+), 100 deletions(-) commit 8da7760544ee3c592f9a884a13b13103b3b5a674 Author: Philip Withnall <philip.withnall@collabora.co.uk> Date: Tue Aug 10 19:43:54 2010 +0100 Split the group editing widgets out of EmpathyContactWidget They can be shared between EmpathyContactWidget and a new EmpathyIndividualWidget, once it's written. libempathy-gtk/Makefile.am | 2 + libempathy-gtk/empathy-contact-widget.c | 307 +-------------- libempathy-gtk/empathy-contact-widget.ui | 104 +----- libempathy-gtk/empathy-groups-widget.c | 600 ++++++++++++++++++++++++++++++ libempathy-gtk/empathy-groups-widget.h | 66 ++++ po/POTFILES.in | 1 + 6 files changed, 688 insertions(+), 392 deletions(-)