After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 626697 - Configure fixes
Configure fixes
Status: RESOLVED FIXED
Product: cheese
Classification: Applications
Component: general
git master
Other All
: Normal normal
: 2.32
Assigned To: Cheese Maintainer(s)
Cheese Maintainer(s)
Depends on:
Blocks:
 
 
Reported: 2010-08-12 00:46 UTC by Thiago Sousa Santos
Modified: 2010-08-12 09:32 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
configure: Properly fail if valac is not available (861 bytes, patch)
2010-08-12 00:47 UTC, Thiago Sousa Santos 		none Details | Review
configure: Use cheese instead of Cheese (822 bytes, patch)
2010-08-12 00:47 UTC, Thiago Sousa Santos 		committed Details | Review

Description Thiago Sousa Santos 2010-08-12 00:46:34 UTC 
Some configure.ac patches following.
Comment 1 Thiago Sousa Santos 2010-08-12 00:47:01 UTC 
Created attachment 167683 [details] [review]
configure: Properly fail if valac is not available

Test if valac is available properly, and fail if not.
Comment 2 Thiago Sousa Santos 2010-08-12 00:47:30 UTC 
Created attachment 167684 [details] [review]
configure: Use cheese instead of Cheese

This way the .ui files are installed in /usr/shared/cheese
as expected, instead of /usr/shared/Cheese
Comment 3 daniel g. siegel 2010-08-12 09:10:47 UTC 
(In reply to comment #1)
> Created an attachment (id=167683) [details] [review]
> configure: Properly fail if valac is not available
> 
> Test if valac is available properly, and fail if not.

afaik, vala is only needed for development. when doing a release, the c sources which are produced by the vala compiler are shipped with the release
Comment 4 daniel g. siegel 2010-08-12 09:29:20 UTC 
though you are right, quoting juergbi:

<juergbi> _ke: that's right. configure from a source tarball shouldn't fail when valac is not available

i added that check to autogen.sh, taking the checks out of tracker
Comment 5 daniel g. siegel 2010-08-12 09:31:33 UTC 
Review of attachment 167684 [details] [review]:

thanks