GNOME Bugzilla – Bug 626622
Add way to get a PeasExtension from a PeasPluginInfo
Last modified: 2010-08-16 19:28:55 UTC
As discussed on IRC
Created attachment 167592 [details] [review] Add way to get a PeasExtension from a PeasPluginInfo So that applications do not need to do their own book-keeping of the existing PeasExtensions.
Created attachment 167865 [details] [review] Add way to get a PeasExtension from a PeasExtensionSet So that applications do not need to do their own book-keeping of the existing PeasExtensions. This variant uses straight equality to compare plugin infos, and doesn't ref the returned object (which I think is more consistent with other libraries).
Review of attachment 167865 [details] [review]: Minor comment from my part. ::: libpeas/peas-extension-set.c @@ +442,3 @@ + for (l = set->priv->extensions; l != NULL; l = l->next) + { + ExtensionItem *item = l->data; Don't you have to cast here?
(In reply to comment #3) > Review of attachment 167865 [details] [review]: > > Minor comment from my part. > > ::: libpeas/peas-extension-set.c > @@ +442,3 @@ > + for (l = set->priv->extensions; l != NULL; l = l->next) > + { > + ExtensionItem *item = l->data; > > Don't you have to cast here? No, you don't.
Attachment 167865 [details] pushed as 436e787 - Add way to get a PeasExtension from a PeasExtensionSet