After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 626570 - [tag] Add resolution tags
[tag] Add resolution tags
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other All
: Normal enhancement
: 0.10.31
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-08-10 21:36 UTC by Thiago Sousa Santos
Modified: 2010-09-07 13:33 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
tag: Adds image resolution tags (2.50 KB, patch)
2010-08-10 21:38 UTC, Thiago Sousa Santos
none Details | Review
tag: Adds image resolution tags (2.50 KB, patch)
2010-08-10 22:35 UTC, Thiago Sousa Santos
none Details | Review

Description Thiago Sousa Santos 2010-08-10 21:36:48 UTC
Proposing to add 2 new tags:

GST_TAG_HORIZONTAL/VERTICAL_RESOLUTION for representing the image/videos resolution. It would be a double in ppi (pixels per inch).

Opening a bug in case someone has an objection for the name/unit/format, and this is new API, so I should get other people approval before pushing it.
Comment 1 Thiago Sousa Santos 2010-08-10 21:38:20 UTC
Created attachment 167546 [details] [review]
tag: Adds image resolution tags

Adds GST_TAG_HORIZONTAL_RESOLUTION and GST_TAG_VERTICAL_RESOLUTION
tags for representing image/video resolutions in ppi

API: GST_TAG_HORIZONTAL_RESOLUTION
API: GST_TAG_VERTICAL_RESOLUTION

Fixes #626570
Comment 2 Thiago Sousa Santos 2010-08-10 22:35:22 UTC
Created attachment 167549 [details] [review]
tag: Adds image resolution tags

Updated after feedback on IRC that resolution might mean
dimensions as well. So renamed it to:

* GST_TAG_IMAGE_HORIZONTAL_PPI
* GST_TAG_IMAGE_VERTICAL_PPI
Comment 3 Stefan Sauer (gstreamer, gtkdoc dev) 2010-08-12 20:43:39 UTC
This could also be mapped in RIFF/INFO for AVI

http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/RIFF.html
'IDPI' 	DotsPerInch

How likely it is that there is a different PPI in one direction? Scanners and cameras usualy have square pixels, right?
Comment 4 Thiago Sousa Santos 2010-08-12 20:54:03 UTC
(In reply to comment #3)
> This could also be mapped in RIFF/INFO for AVI
> 
> http://www.sno.phy.queensu.ca/~phil/exiftool/TagNames/RIFF.html
> 'IDPI'     DotsPerInch
> 
> How likely it is that there is a different PPI in one direction? Scanners and
> cameras usualy have square pixels, right?

Yes, not sure how to relate this with PAR in a nice way.

And for the naming, DPI seems to be the most common usage, but PPI is the 'correct' term when talking about pixels. But DPI is good enough to me.
Comment 5 Thiago Sousa Santos 2010-09-07 13:26:23 UTC
Pushed the tags to -base.

commit d54ba9394520baa00655503b04d015a0cbb89515
Author: Thiago Santos <thiago.sousa.santos@collabora.co.uk>
Date:   Tue Sep 7 08:46:15 2010 -0300

    tag: exif: Adds mappings for new image ppi tags
    
    Adds mappings for GST_TAG_IMAGE_HORIZONTAL/VERTICAL_PPI into
    our exif lib
    
    Tests included.
    
    Fixes #626570

commit 7d4bdbf5cef6e1b941a9f600aeea5dd472db76a6
Author: Thiago Santos <thiago.sousa.santos@collabora.co.uk>
Date:   Tue Sep 7 08:22:27 2010 -0300

    tags: Add GST_TAG_IMAGE_HORIZONTAL/VERTICAL_PPI tags
    
    Adds new tags for representing the intended PPI of images/videos
    
    API: GST_TAG_IMAGE_HORIZONTAL_PPI
    API: GST_TAG_IMAGE_VERTICAL_PPI

    Fixed #626570