After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 626543 - Rework unlinking code
Rework unlinking code
Status: RESOLVED FIXED
Product: folks
Classification: Platform
Component: libfolks
git master
Other Linux
: Normal normal
: gnome-2.32
Assigned To: folks-maint
folks-maint
Depends on:
Blocks: 626544
 
 
Reported: 2010-08-10 16:06 UTC by Philip Withnall
Modified: 2010-08-11 00:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Squashed diff of the unlinking branch (12.08 KB, patch)
2010-08-10 16:06 UTC, Philip Withnall 		committed Details | Review

Description Philip Withnall 2010-08-10 16:06:28 UTC 
Created attachment 167527 [details] [review]
Squashed diff of the unlinking branch

http://git.collabora.co.uk/?p=user/pwith/folks;a=shortlog;h=refs/heads/unlinking

The unlinking code didn't actually quite work. This branch makes it work, though it's a little messy. Ideas on how to make it neater are welcome.
Comment 1 Travis Reitter 2010-08-11 00:02:22 UTC 
Review of attachment 167527 [details] [review]:

Like you said, some of the unlinking code is a little complicated. I examined it for a bit, but couldn't find a simpler way of doing it. The aggregator is just bound to be complex, since it's got a lot of details to track.

Committed, ending with 2d94025