After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 626507 - Connection error message is not shown completely
Connection error message is not shown completely
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Contact List
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
: 628167 631859 (view as bug list)
Depends on: 623925 630025
Blocks:
 
 
Reported: 2010-08-10 08:37 UTC by Xavier Claessens
Modified: 2011-08-29 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
illustration (17.82 KB, image/png)
2010-08-10 08:37 UTC, Xavier Claessens
  Details
Patch for fix bug. (426 bytes, patch)
2010-12-09 12:35 UTC, Robert Sajdok
none Details | Review
Patch for fix bug. (460 bytes, patch)
2010-12-09 19:38 UTC, Robert Sajdok
none Details | Review

Description Xavier Claessens 2010-08-10 08:37:28 UTC
Created attachment 167485 [details]
illustration

See attached screenshot.

I think that label should wrap on multi lines, just like the topic label on chatroom.
Comment 1 Guillaume Desmottes 2010-08-30 08:19:34 UTC
*** Bug 628167 has been marked as a duplicate of this bug. ***
Comment 2 Guillaume Desmottes 2010-08-30 10:24:38 UTC
GTK3 will allow us to do that easily using
http://library.gnome.org/devel/gtk/2.90/GtkSizeRequest.html#GtkSizeRequest-struct
Comment 3 Guillaume Desmottes 2010-10-11 12:06:00 UTC
*** Bug 631859 has been marked as a duplicate of this bug. ***
Comment 4 Guillaume Desmottes 2010-10-12 09:35:17 UTC
According to the GTK test testheightforwidth
http://git.Collabora.co.uk/?p=user/cassidy/empathy;a=shortlog;h=refs/heads/wrap-msg-626507
should do it. It does wrap on multi-lines, but still increase the size of the window for some reason. Help welcome.
Comment 5 Omer Akram 2010-12-05 10:38:59 UTC
ubuntu bug: https://bugs.launchpad.net/hundredpapercuts/+bug/681413
Comment 6 Robert Sajdok 2010-12-09 12:35:36 UTC
Created attachment 176128 [details] [review]
Patch for fix bug.

I fixed this bug. Please look at screenshot and review my patch.
https://bugs.launchpad.net/empathy/+bug/681413/comments/4
Comment 7 Robert Sajdok 2010-12-09 18:55:24 UTC
Comment on attachment 176128 [details] [review]
Patch for fix bug.

=== modified file 'src/empathy-main-window.c'
--- src/empathy-main-window.c	2010-08-27 09:57:14 +0000
+++ src/empathy-main-window.c	2010-12-08 23:10:21 +0000
@@ -588,6 +588,7 @@
 			  G_CALLBACK (main_window_error_retry_clicked_cb),
 			  window);
 
+	gtk_widget_set_tooltip_text (window->errors_vbox, message);
 	gtk_widget_show (window->errors_vbox);
 
 	g_hash_table_insert (window->errors, g_object_ref (account), info_bar);
Comment 8 Robert Sajdok 2010-12-09 19:38:51 UTC
Created attachment 176147 [details] [review]
Patch for fix bug.

Sorry for the mistake. I attach the correct patch. Should be correct.
Comment 9 Guillaume Desmottes 2010-12-13 09:41:23 UTC
That's actually a pretty good idea. I updated your patch to apply on master and merged it.

commit b4930806a93a8b365400e563b8fa359c00c4016a
Author: Robert Sajdok <robert.sajdok@gmail.com>
Date:   Mon Dec 13 10:40:23 2010 +0100

    main-window: add a tooltip on connection error info bars (#626507)

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.