After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 626474 - use standard icon names for stock icons
use standard icon names for stock icons
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: [obsolete] stock-icons
unspecified
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2010-08-09 19:10 UTC by Matthias Clasen
Modified: 2010-10-24 10:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
a patch (290.82 KB, patch)
2010-08-09 23:47 UTC, Matthias Clasen 		none Details | Review
print backend patch (4.10 KB, patch)
2010-08-10 00:02 UTC, Matthias Clasen 		none Details | Review

Description Matthias Clasen 2010-08-09 19:10:54 UTC 
See http://live.gnome.org/GtkNamingSpecInvestigation for some investigation into how stock icons map onto standard icon names.
Comment 1 Matthias Clasen 2010-08-09 23:47:31 UTC 
Created attachment 167468 [details] [review]
a patch

This patch makes use of the existing mapping from stock ids to icon names (which was basically a 1-1 mapping so far), and makes it map to standard icon names where they exist.

There are still some non-standard icons left afterwards, and I just left them as they are now:
gtk-dnd
gtk-dnd-multiple
gtk-color-picker
gtk-apply
gtk-cancel
gtk-no
gtk-ok
gtk-yes
gtk-convert
gtk-select-color
gtk-select-font
gtk-orientation-portrait
gtk-orientation-landscape
gtk-orientation-reverse-portrait
gtk-orientation-reverse-landscape
gtk-page-setup
gtk-undelete
gtk-undelete
gtk-connect
gtk-disconnect
gtk-edit
gtk-caps-lock-warning
gtk-index

For directional variants of icons such as go-back, the patch first looks for
gtk-back-ltr/-rtl, and then at gtk-back.

One set of icons where I have deviated from the 1-1 mapping for non-standard icon names is printers: The patch uses printer, printer-error, printer-warning,
printer-info instead of gtk-print, gtk-print-error, gtk-print-warning, gtk-print-report. A second patch will be needed to make the print backends use 
printer-... icon names. This will help separate the action (document-print) from the device (printer-...).
Comment 2 Matthias Clasen 2010-08-10 00:02:06 UTC 
Created attachment 167469 [details] [review]
print backend patch

Make the print backends use standard icon names for printer icons.
Comment 3 Hylke Bons 2010-08-10 08:24:40 UTC 
Sweet! Thanks :)
Comment 4 Matthias Clasen 2010-08-18 23:41:52 UTC 
Committed to both 2.90 and 2.22
Comment 5 Gökcen Eraslan 2010-10-24 10:11:32 UTC 
Can you please provide a way to keep old-named icons, at least for 2.2x branch? Maybe as a configure parameter? Applications like Firefox still uses those icons, and people issue bugs about that:

https://bugzilla.gnome.org/show_bug.cgi?id=629878