After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 626428 - libpeasui requires Gtk 2.22 for a single function
libpeasui requires Gtk 2.22 for a single function
Status: RESOLVED FIXED
Product: libpeas
Classification: Platform
Component: libpeas-gtk
git master
Other Linux
: Normal normal
: ---
Assigned To: libpeas-maint
libpeas-maint
Depends on:
Blocks:
 
 
Reported: 2010-08-09 12:37 UTC by Chris Lord
Modified: 2010-09-01 07:24 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Allow building with Gtk < 2.22 (1.41 KB, patch)
2010-08-09 12:37 UTC, Chris Lord 		committed Details | Review

Description Chris Lord 2010-08-09 12:37:01 UTC 
Created attachment 167423 [details] [review]
Allow building with Gtk < 2.22

libpeasui requires Gtk 2.22 for gtk_window_has_group. As a lot of distributions don't have 2.22 yet and this isn't a particularly hard/large function, it'd be nice if this wasn't necessary (at least until the next run of distro releases).

The attached patch adds a local implementation of said function if the Gtk version is less than 2.22.
Comment 1 Steve Frécinaux 2010-08-09 14:19:27 UTC 
This could go with a --with-gtk=2.0 configure flag for 2.32. Shouldn't you modify the configure.ac as well to lower the requirement?
Comment 2 Chris Lord 2010-08-11 14:17:50 UTC 
The configure.ac already only asked for 2.16, so I guess this function slipped through unnoticed at some point?