GNOME Bugzilla – Bug 626221
libpeas requires an unnecessarily high version of gobject-introspection
Last modified: 2010-08-16 19:30:14 UTC
Created attachment 167262 [details] [review] Build with older versions of gobject-introspection libpeas requires version 0.9.0 of gobject-introspection, but it builds and works against earlier versions fine. Attached is a patch that relaxes the version requirement to 0.6.9 (the version in Fedora 13).
You attached your file as application/octet-stream instead of patch...
The patch looks alright. Feel free to push it to master.
Thanks, pushed.
Apologies, I forgot to add the bugzilla url to the commit log before pushing - Will endeavor not to make this mistake in the future.
Reopening, as there are extra types in GObject introspection 0.6 that need conditional support.
Created attachment 167752 [details] [review] Support GObject introspection 0.6.x gobject-introspection 0.9.x removes lots of unnecessary types. Detect the version and conditionally enable support for these removed types so libpeas can be used with gobject-introspection 0.6.x.
Just had this: http://git.gnome.org/browse/libpeas/commit/?id=52e493e1e91b98bb75356b762b8e7dcef2f504cc pointed out to me, so I'll rewrite this patch based on this and re-attach tomorrow.
I guess we should rather revert your previous patch and let you use a newer g-i. I had forgotten about the removed types... BTW if I recall correctly, the old types were actually not used in the typelib.
Yes, I do think this should be reverted, it seems maintaining support for both old and new is probably more trouble than it's worth. I guess this should probably be marked as invalid (I'll leave this up to you)
I reverted the patch, and I'm marking this bug as WONTFIX. I think you would be better started to just update your g-i version at this point...