After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 626176 - Port to upower
Port to upower
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
2.31.x
Other Linux
: Normal normal
: ---
Assigned To: Martin Pitt
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2010-08-06 10:03 UTC by Martin Pitt
Modified: 2010-08-10 07:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
port to upower (5.01 KB, patch)
2010-08-06 10:49 UTC, Martin Pitt 		reviewed Details | Review

Description Martin Pitt 2010-08-06 10:03:08 UTC 
devkit-power-gobject is deprecated and will be removed in future versions of upower (in fact, 0.9.5 is the last one which shipped it).

So gdm needs to be ported to libupower-glib, similar to gnome-session.

I'll have a go at this, it seems very easy to do.
Comment 1 Martin Pitt 2010-08-06 10:49:05 UTC 
Created attachment 167246 [details] [review]
port to upower

Pretty straightforward. I added a "use upower" line to configure summary, too.

Tested here on both trunk and 2.30.4, working flawlessly.

Can I commit this?

Thanks,

Martin
Comment 2 Matthias Clasen 2010-08-09 17:46:10 UTC 
Patch looks obvious enough to me.
Comment 3 Martin Pitt 2010-08-10 07:03:33 UTC 
Thanks for the review!

Committed:
http://git.gnome.org/browse/gdm/commit/?id=861261e434be78382928042035d129e8c3deb7f1