GNOME Bugzilla – Bug 626162
No audio/video icon in the contact list
Last modified: 2011-08-29 10:12:37 UTC
Empathy master and folks 0.1.12. Loads of contacts don't have the audio/video icon in the contact list any more while they actually have the capabilities. Actually the contact menu works properly (they are callable) so that's probably a regression in the contact list view (or model?) introduced with folks.
http://git.collabora.co.uk/?p=user/pwith/empathy;a=shortlog;h=refs/heads/capabilities-fix-626162 The fix is a bit hacky, but necessary since libfolks doesn't have capabilities support yet. This can be reverted once libfolks grows capabilities support.
Created attachment 167242 [details] [review] Fix capability change notification in the EmpathyIndividualStore
Review of attachment 167242 [details] [review]: Please open a bug refering to the FIXME you introduced. ::: libempathy-gtk/empathy-individual-store.c @@ +753,2 @@ static void +individual_store_contact_updated_cb (EmpathyContact *contact, GParamSpec *pspec, Style is wrong. One arg per line please. @@ +785,3 @@ + * through the EmpathyContact for them. */ + contact = empathy_contact_dup_from_folks_individual (individual); + g_object_set_data (G_OBJECT (contact), "individual", individual); Shouldn't we use g_object_set_data_full, pass g_object_unref as destroy and give it a reference?
(In reply to comment #3) > Review of attachment 167242 [details] [review]: > > Please open a bug refering to the FIXME you introduced. Bug #626179. > ::: libempathy-gtk/empathy-individual-store.c > @@ +753,2 @@ > static void > +individual_store_contact_updated_cb (EmpathyContact *contact, GParamSpec > *pspec, > > Style is wrong. One arg per line please. OK. I'll change that when I commit if there are no other problems which require a new patch iteration. > @@ +785,3 @@ > + * through the EmpathyContact for them. */ > + contact = empathy_contact_dup_from_folks_individual (individual); > + g_object_set_data (G_OBJECT (contact), "individual", individual); > > Shouldn't we use g_object_set_data_full, pass g_object_unref as destroy and > give it a reference? I think that would introduce a reference cycle. The lifecycle of EmpathyContact and FolksIndividual should be the same anyway.
commit 878faf8c3357c3b96a5dc49d53754382079bd470 Author: Philip Withnall <philip.withnall@collabora.co.uk> Date: Fri Aug 6 10:40:38 2010 +0100 Fix capability change notification in the EmpathyIndividualStore Closes: bgo#626162 libempathy-gtk/empathy-individual-store.c | 41 ++++++++++++++++++++++++---- 1 files changed, 35 insertions(+), 6 deletions(-)