After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 626153 - Evince doesn't show descriptions of file attachments
Evince doesn't show descriptions of file attachments
Status: RESOLVED OBSOLETE
Product: evince
Classification: Core
Component: PDF
2.30.x
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-08-05 22:41 UTC by Tobias Mueller
Modified: 2018-05-22 13:57 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
PDF testcase (12.75 KB, application/pdf)
2010-08-05 22:42 UTC, Tobias Mueller
  Details
Proposed patch to show description as tooltip (1.27 KB, patch)
2010-11-10 11:07 UTC, Fernando Herrera
none Details | Review
Updated patch to show the desciption also in the icon view (2.05 KB, patch)
2010-11-10 11:42 UTC, Fernando Herrera
needs-work Details | Review

Description Tobias Mueller 2010-08-05 22:41:24 UTC
The follow LaTeX document creates a PDF with an attachment with a description.

\documentclass[a4paper,10pt]{article}
\usepackage{embedfile}
\begin{document}
sources \embedfile[desc={Sources of tis PDF}, mimetype=text/x-tex]{\jobname.tex} end
\end{document}


Okular shows the description, Evince does not. I guess it would be nice to have that at least in a tooltip, or underneath the filename in the sidepan.
Comment 1 Tobias Mueller 2010-08-05 22:42:15 UTC
Created attachment 167222 [details]
PDF testcase
Comment 2 Fabio Durán Verdugo 2010-08-09 18:36:17 UTC
I can reproduce in evince 2.31.90
Comment 3 Fernando Herrera 2010-11-10 11:07:56 UTC
Created attachment 174184 [details] [review]
Proposed patch to show description as tooltip

This patch shows the description as a tooltip in the IconView. I'm not sure if this is the most intuitive solution, or we should try to write it with some special markup
Comment 4 Fernando Herrera 2010-11-10 11:42:51 UTC
Created attachment 174187 [details] [review]
Updated patch to show the desciption also in the icon view

Updated patch with KaL comments
Comment 5 Carlos Garcia Campos 2010-11-14 12:29:33 UTC
Review of attachment 174187 [details] [review]:

Thanks for the patch, there are several issues though. We need to set ellipsize property for the text cell renderer or the sidebar will grow when the description text is long. I think we should use a single column and change the orientation to horizontal. The problem is that GtkIconView uses expand=false for its cells, so ellipsize + not expand means only dots are displayed. So we have to create our own renderers and use the GtkCellLayout outrselves instead of just setting text and pixbuf column properties.

::: shell/ev-sidebar-attachments.c
@@ +651,3 @@
 				    COLUMN_NAME, ev_attachment_get_name (attachment),
+				    COLUMN_LABEL, label,
+				    COLUMN_DESCRIPTION, ev_attachment_get_description (attachment),

GtkIconView uses gtk_tooltip_set_markup() so the description text should be escaped too.
Comment 6 GNOME Infrastructure Team 2018-05-22 13:57:21 UTC
-- GitLab Migration Automatic Message --

This bug has been migrated to GNOME's GitLab instance and has been closed from further activity.

You can subscribe and participate further through the new bug through this link to our GitLab instance: https://gitlab.gnome.org/GNOME/evince/issues/166.