After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 626126 - Draw differently narrow breaking spaces
Draw differently narrow breaking spaces
Status: RESOLVED FIXED
Product: gtksourceview
Classification: Platform
Component: General
git master
Other All
: Normal enhancement
: ---
Assigned To: GTK Sourceview maintainers
GTK Sourceview maintainers
Depends on:
Blocks:
 
 
Reported: 2010-08-05 16:52 UTC by Claude Paroz
Modified: 2011-02-12 16:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
narrowed spaces v1 (2.61 KB, patch)
2010-11-15 09:37 UTC, Ignacio Casal Quinteiro (nacho)
committed Details | Review
narrowed spaces screenshot (4.94 KB, image/jpeg)
2010-11-15 09:37 UTC, Ignacio Casal Quinteiro (nacho)
  Details

Description Claude Paroz 2010-08-05 16:52:28 UTC
Currently all breaking spaces are drawn similarly. I suggest to visually draw differently thin breaking spaces (U+202F, NARROW NO-BREAK SPACE). This character is commonly used in French.

See e.g. http://en.wikipedia.org/wiki/Non-breaking_space: "No-break thin space, known in Unicode as "NARROW NO-BREAK SPACE" (U+202F). This is required for French punctuation (before ?, ! or ;)."

I suggest to use the same triangle as the non-breaking space, but narrower (isoceles triangle instead of equilateral).
Comment 1 Ignacio Casal Quinteiro (nacho) 2010-11-15 09:37:09 UTC
Created attachment 174498 [details] [review]
narrowed spaces v1

So here it is the patch and a screenshot following.
Comment 2 Ignacio Casal Quinteiro (nacho) 2010-11-15 09:37:46 UTC
Created attachment 174499 [details]
narrowed spaces screenshot

the screenshot, narrowed with fill color
Comment 3 Nicolas Delvaux 2010-11-15 11:37:20 UTC
The screenshot looks great.
Do you need any special feedback before including this patch?
Comment 4 Ignacio Casal Quinteiro (nacho) 2010-11-15 14:02:09 UTC
Mainly I need to know if the drawing is ok for you or you want something different.
Comment 5 Alexandre Franke 2010-11-15 17:02:33 UTC
What about having half a triangle for the narrow space? That would make it easier to distinguish it from the full triangle. I think current patch doesn't really make it easy to see which symbol matches a given character.
Comment 6 Ignacio Casal Quinteiro (nacho) 2010-12-19 01:20:49 UTC
Can you provide a mockup?
Comment 7 Alexandre Franke 2010-12-19 11:20:56 UTC
Yeah sure, that was on my todo list but I got distracted by other things. I'll come back to you with something tomorrow.
Comment 8 Ignacio Casal Quinteiro (nacho) 2011-02-09 22:45:57 UTC
ping here, should I push my patch?
Comment 9 Nicolas Delvaux 2011-02-12 12:15:40 UTC
As already said, it looks good to me.
It's true that the two symbols are similar, but the relative chars are close too (one is just narrower than the other), so it seems logical.

I think both are still recognizable, which is the more important.
Comment 10 Alexandre Franke 2011-02-12 14:11:00 UTC
Sorry for the delay. I couldn't manage to make something readable. Half a triangle, as I told in comment #5, happens to be too small. Please push your patch and excuse me for my lack of responsiveness.
Comment 11 Ignacio Casal Quinteiro (nacho) 2011-02-12 16:08:04 UTC
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.