After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 626123 - Some Magnifier DBus methods incorrectly interpret rectangles
Some Magnifier DBus methods incorrectly interpret rectangles
Status: RESOLVED FIXED
Product: gnome-shell
Classification: Core
Component: magnifier
unspecified
Other Linux
: Normal normal
: ---
Assigned To: gnome-shell-maint
gnome-shell-maint
Depends on:
Blocks:
 
 
Reported: 2010-08-05 16:27 UTC by Joseph Scheuhammer
Modified: 2013-12-04 18:03 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Some Magnifier DBus methods incorrectly interpret rectangles. (4.18 KB, patch)
2010-08-06 17:15 UTC, Joseph Scheuhammer 		committed Details | Review

Description Joseph Scheuhammer 2010-08-05 16:27:30 UTC 
Some Magnifier and ZoomRegion methods take/return a 'RectBounds'.  Currently, the magnifier DBus code treats them as [left, top, width, height], but that is wrong.  It should see them as [left, top, right, bottom].

The affected methods are:

Magnifier:
- createZoomRegion()

ZoomRegion:
- setRoi()
- getRoi()
- moveResize()
Comment 1 Joseph Scheuhammer 2010-08-06 17:15:37 UTC 
Created attachment 167264 [details] [review]
Some Magnifier DBus methods incorrectly interpret rectangles.

Modified methods to use [left, top, right, bottom] instead of
[left, top, width, height].
Comment 2 Owen Taylor 2010-08-19 18:18:13 UTC 
Review of attachment 167264 [details] [review]:

I'll assume you are right about what the D-Bus methods do. Code looks correct.
Comment 3 Joseph Scheuhammer 2010-09-10 16:07:09 UTC 
Attachment 167264 [details] pushed as 399ebcc - Some Magnifier DBus methods incorrectly interpret rectangles.