After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 626002 - dconf.vala:66.3-93.10: error: missing break statement at end of switch section
dconf.vala:66.3-93.10: error: missing break statement at end of switch section
Status: RESOLVED FIXED
Product: dconf
Classification: Core
Component: general
0.3.x
Other Linux
: Normal normal
: ---
Assigned To: dconf-maint
dconf-maint
Depends on:
Blocks:
 
 
Reported: 2010-08-04 07:14 UTC by sathyz
Modified: 2010-08-23 14:15 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
add break statement (284 bytes, patch)
2010-08-04 07:14 UTC, sathyz 		none Details | Review

Description sathyz 2010-08-04 07:14:51 UTC 
Created attachment 167098 [details] [review]
add break statement

building dconf failed saying 

...
ln -fs libdconf.so.0 libdconf.so
  GISCAN dconf-0.3.gir
  GICOMP dconf-0.3.gir
  GEN    dconf.deps
make[1]: Leaving directory `/d2/gnome-shell/source/dconf/client'
Making all in bin
make[1]: Entering directory `/d2/gnome-shell/source/dconf/bin'
  VALAC  dconf_vala.stamp
dconf.vala:66.3-93.10: error: missing break statement at end of switch section
Compilation failed: 1 error(s), 0 warning(s)
make[1]: *** [dconf_vala.stamp] Error 1
make[1]: Leaving directory `/d2/gnome-shell/source/dconf/bin'
make: *** [all-recursive] Error 1
...

I'm using vala - 0.9.4. Works after adding the break statement.
Comment 1 Richard Hughes 2010-08-04 09:47:36 UTC 
commit 66dcd38beb93f8c2051b5318508515e396b0e5dd
Author: Richard Hughes <richard@hughsie.com>
Date:   Wed Aug 4 10:47:14 2010 +0100

    Fix a trivial compile error when using vala 0.9.4. Fixes bgo#626002
Comment 2 Allison Karlitskaya (desrt) 2010-08-04 12:31:00 UTC 
oh this bug is very obnoxious.

i *just* removed that 'break;' statement due to the new vala compiler complaining of it being unreachable

*sigh*.
Comment 3 Allison Karlitskaya (desrt) 2010-08-04 12:33:55 UTC 
actually, I'm reopening this.  Although it would have been nice to have this fix for the just-released tarballs, probably the git version should do the thing that matches with the Vala git version...
Comment 4 Allison Karlitskaya (desrt) 2010-08-04 12:35:25 UTC 
(on Vala)

commit 97d4e19869293963b3b5da6f3d5ce3fcded96349
Author: Luca Bruno <lethalman88@gmail.com>
Date:   Fri Jul 30 00:08:35 2010 -0700

    glib-2.0: Add [NoReturn] to GLib.error.
Comment 5 Allison Karlitskaya (desrt) 2010-08-23 14:15:56 UTC 
okay.  I bumped our vala depend and reverted the commit made by Richard

everything should be good now.