GNOME Bugzilla – Bug 625988
builddir != srcdir issues
Last modified: 2010-08-05 13:16:10 UTC
need to add $(top_builddir)/glib to a couple of makefiles so they can include glibconfig.h, otherwise... Making all in tests gcc-3.3 -DHAVE_CONFIG_H -I. -I/Source/glib/glib/glib/tests -I../.. -g -I/Source/glib/glib -I/Source/glib/glib/glib -DSRCDIR=\""/Source/glib/glib/glib/tests"\" -DG_ENABLE_DEBUG -I/opt/local/include -I/usr/X11R6/include -arch ppc -g -Wall -Wno-long-double -Os -pipe -no-cpp-precomp -Dsocklen_t=int -DMAC_OS_X_VERSION_MAX_ALLOWED=MAC_OS_X_VERSION_10_3 -MT testing.o -MD -MP -MF .deps/testing.Tpo -c -o testing.o /Source/glib/glib/glib/tests/testing.c In file included from /Source/glib/glib/glib/galloca.h:34, from /Source/glib/glib/glib/glib.h:32, from /Source/glib/glib/glib/tests/testing.c:23: /Source/glib/glib/glib/gtypes.h:34:24: glibconfig.h: No such file or directory /Source/glib/glib/glib/gtypes.h:415:2: #error unknown ENDIAN type In file included from /Source/glib/glib/glib/glib.h:33, from /Source/glib/glib/glib/tests/testing.c:23: /Source/glib/glib/glib/garray.h:50: error: parse error before "guint8" /Source/glib/glib/glib/garray.h:50: warning: no semicolon at end of struct or union /Source/glib/glib/glib/garray.h:52: error: parse error before '}' token etc, etc...
Created attachment 167075 [details] [review] patch that resolves the issue for me
Review of attachment 167075 [details] [review]: Looks right to me. Previously this wasn't necessary because automake throws $(top_builddir) into DEFAULT_INCLUDES, it seems.
I was curious about why 'make distcheck' wasn't failing and it's because we are disting glibconfig.h. This problem only affects from-git builds. That's obviously a bug, but I will open another one for that. The patch here has been committed.