After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 625926 - libnotify misses a Requires: gtk+-2.0 in its pkg-config file
libnotify misses a Requires: gtk+-2.0 in its pkg-config file
Status: RESOLVED FIXED
Product: libnotify
Classification: Platform
Component: general
git master
Other Linux
: Normal normal
: ---
Assigned To: William Jon McCann
Depends on:
Blocks:
 
 
Reported: 2010-08-03 11:14 UTC by Bin Li
Modified: 2010-08-06 09:07 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
the patch for gtk in pc config file (594 bytes, patch)
2010-08-03 11:14 UTC, Bin Li
none Details | Review

Description Bin Li 2010-08-03 11:14:52 UTC
Created attachment 167037 [details] [review]
the patch for gtk in pc config file

Ekiga fails to build with a

libtool: compile:  g++ -DHAVE_CONFIG_H -I.  -I../../../..
-I../../../../lib/engine/framework  -I../../../../lib/engine/notification
-I/usr/include/sigc++-2.0  -I/usr/lib64/sigc++-2.0/include -pthread
-I/usr/include/glib-2.0  -I/usr/lib64/glib-2.0/include -I/usr/include/dbus-1.0 
-I/usr/lib64/dbus-1.0/include -fmessage-length=0 -O2 -Wall  -D_FORTIFY_SOURCE=2
-fstack-protector -funwind-tables  -fasynchronous-unwind-tables -g
-fstack-protector -fexceptions -Wall  -Wextra -Winit-self -Wswitch-default
-Wswitch-enum -Wstrict-aliasing=2  -Wfloat-equal -Wshadow -MT libnotify-main.lo
-MD -MP -MF  .deps/libnotify-main.Tpo -c 
../../../../lib/engine/components/libnotify/libnotify-main.cpp  -fPIC  -DPIC -o
.libs/libnotify-main.o
In file included from /usr/include/libnotify/notify.h:28:0,
                 from 
../../../../lib/engine/components/libnotify/libnotify-main.cpp:41:
/usr/include/libnotify/notification.h:28:21: fatal error: gtk/gtk.h: No  such
file or directory

Now in the libnotify.pc.in

Requires: @link_modules@

And in the configure.ac file not have the gtk.

link_modules="glib-2.0 >= $REQ_GLIB_VERSION, dbus-1 >= $REQ_DBUS_VERSION, dbus-glib-1 >= $REQ_DBUS_VERSION, gmodule-2.0"

I make a patch for it.
Comment 1 Vincent Untz 2010-08-06 09:07:29 UTC
libnotify 0.5.1 can be used with GTK+ 2 and GTK+ 3, so this is done by design. It's most probably a bug in how ekiga is setup to build, since it should link to GTK+ anyway, and instead, it relies on libnotify to bring the right flags.