After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 625904 - Port to GSettings
Port to GSettings
Status: RESOLVED FIXED
Product: gnome-games-superseded
Classification: Deprecated
Component: general
trunk
Other Linux
: Normal normal
: ---
Assigned To: gnome-games-general-maint
GNOME Games maintainers
Depends on: 664944 666040 666041 666042 666043 666044 666045 666046 667321
Blocks: 444693 622558
 
 
Reported: 2010-08-03 01:00 UTC by Robert Ancell
Modified: 2012-01-11 14:44 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Gnobots2 migration (18.08 KB, patch)
2011-08-26 17:13 UTC, Marc Ruiz - radykal -
none Details | Review
Gnobots2 Gsettings migration schema file (5.11 KB, patch)
2011-08-26 17:21 UTC, Marc Ruiz - radykal -
none Details | Review
GConf to GSettings migration (22.77 KB, patch)
2011-08-28 16:06 UTC, Marc Ruiz - radykal -
none Details | Review
glines GConf to GSettings migration (2.33 KB, patch)
2011-08-28 16:52 UTC, Marc Ruiz - radykal -
needs-work Details | Review
gnobots: updated patch (22.69 KB, patch)
2011-08-29 22:31 UTC, Thomas Andersen
needs-work Details | Review
glines GConf to GSettings migration (29.00 KB, patch)
2011-08-31 19:16 UTC, Marc Ruiz - radykal -
none Details | Review
glines GConf to GSettings migration (13.12 KB, patch)
2011-08-31 20:13 UTC, Marc Ruiz - radykal -
none Details | Review
glines delete old schema file (3.34 KB, patch)
2011-08-31 20:17 UTC, Marc Ruiz - radykal -
none Details | Review
glines GConf to GSettings migration (16.19 KB, patch)
2011-09-05 20:01 UTC, Marc Ruiz - radykal -
committed Details | Review

Comment 2 Thomas Andersen 2011-08-01 18:48:08 UTC
iagno and gnomine are done
Comment 4 Marc Ruiz - radykal - 2011-08-26 17:13:36 UTC
Created attachment 194864 [details] [review]
Gnobots2 migration

Is my first patch ever, so im not sure if all will be ok :)
Comment 5 Marc Ruiz - radykal - 2011-08-26 17:21:01 UTC
Created attachment 194865 [details] [review]
Gnobots2 Gsettings migration schema file

Last patch was missing the new schema xml file. Here is. Sorry :(
Comment 6 Thomas Andersen 2011-08-28 09:54:57 UTC
Hi Marc,

Thanks for the patch :) I think that there is a small oversight in the properties file. There is still a call to games_conf_get_keyval_with_default in the load_keys function there. Also the settings variable is newer set in that file. The schema file seems to have few places with < _summary> instead of <_summary>.

Otherwise it looks good. I'll commit the patch with the fixes before the 3.1.90 release on monday.
Comment 7 Marc Ruiz - radykal - 2011-08-28 16:06:54 UTC
Created attachment 194968 [details] [review]
GConf to GSettings migration

I hope all be ok now
Comment 8 Marc Ruiz - radykal - 2011-08-28 16:52:17 UTC
Created attachment 194974 [details] [review]
glines GConf to GSettings migration

glines migration
Comment 9 Thomas Andersen 2011-08-29 22:31:51 UTC
Created attachment 195130 [details] [review]
gnobots: updated patch

I updated your patch Marc with a few fixes (use extern GSettings variable, change '_' to '-' in a settings name, removed reference to non-existing g_settings_get_keyval, indentation in xml file)

It builds now but unfortunately it turns out that libgames-support/games-controls.[ch] needs to be ported as well. Gnect and gnibbles both depend on that code so we need to port all three games at the same time. I won't be able to do that before the 3.1.90 release tonight.
Comment 10 Thomas Andersen 2011-08-29 22:32:26 UTC
Review of attachment 194974 [details] [review]:

the patch only contains a new schema file for gsettings
Comment 11 Marc Ruiz - radykal - 2011-08-31 19:16:12 UTC
Created attachment 195342 [details] [review]
glines GConf to GSettings migration

It builds :=)
Comment 12 Marc Ruiz - radykal - 2011-08-31 20:13:22 UTC
Created attachment 195348 [details] [review]
glines GConf to GSettings migration

Last had some gnobots changes, this is only the glines changes on current master.
Comment 13 Marc Ruiz - radykal - 2011-08-31 20:17:57 UTC
Created attachment 195349 [details] [review]
glines delete old schema file
Comment 14 Marc Ruiz - radykal - 2011-09-01 12:50:52 UTC
I have done game-controls migration. also did gnect, ill start gnibbles but quadrapassel is complaining too due to game-controls changes, so ill have to modify it too.
Comment 15 Marc Ruiz - radykal - 2011-09-05 20:01:44 UTC
Created attachment 195729 [details] [review]
glines GConf to GSettings migration

Latest glines migration. Indentation fixed.
Comment 16 Thomas Andersen 2011-09-05 20:22:10 UTC
Comment on attachment 195729 [details] [review]
glines GConf to GSettings migration

Committed to master:
http://git.gnome.org/browse/gnome-games/commit/?id=96a72639ba3c90130997704e0f62dd6b00cffb4d

Thanks Marc!
Comment 17 Marc Ruiz - radykal - 2011-12-06 16:58:23 UTC
Hey, im again with this migration. Which games are still needing the change to gsettings?
Comment 18 Robert Ancell 2011-12-13 00:57:08 UTC
The remaining tasks are
swell-foop (bug 664944)
gnect (bug 666040)
gnibbles (bug 666041)
gnobots2 (bug 666042)
gnoski (bug 666043)
gtali (bug 666044)
lightsoff (bug 666045)
quadrapassel (bug 666046)
Comment 19 Robert Ancell 2011-12-13 00:59:35 UTC
The remaining tasks are
swell-foop (bug 664944)
gnect (bug 666040)
gnibbles (bug 666041)
gnobots2 (bug 666042)
gnoski (bug 666043)
gtali (bug 666044)
lightsoff (bug 666045)
quadrapassel (bug 666046)
Comment 20 Robert Ancell 2012-01-04 23:17:21 UTC
Also gnome-sudoku (bug 667321)