After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 625896 - Port to GSettings
Port to GSettings
Status: RESOLVED FIXED
Product: totem
Classification: Core
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: General Totem maintainer(s)
General Totem maintainer(s)
Depends on: 628777
Blocks: 622558
 
 
Reported: 2010-08-03 00:42 UTC by Robert Ancell
Modified: 2010-09-04 15:48 UTC
See Also:
GNOME target: ---
GNOME version: ---



Comment 1 Philip Withnall 2010-08-21 19:38:08 UTC
Branch here: http://git.gnome.org/browse/totem/log/?h=gsettings

The main problem we need to solve is what to do with the url-handlers and thumbnailers GConf schemas. I think they should move to gsettings-desktop-schemas, so in the branch I've removed them from Totem. Another bug can be opened to add them to the gsettings-desktop-schemas module.
Comment 2 Philip Withnall 2010-09-04 15:48:37 UTC
Merged! We don't need to wait for bug #628777 to be fixed, since none of Totem depends directly on those schemas.

commit f014ff99c1c6666dcd4955862fda2eb909e9a0ec
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Thu Aug 19 21:38:09 2010 +0100

    Improve naming of the visualization GSettings keys

 data/org.gnome.totem.gschema.xml.in.in    |   10 +++++-----
 data/totem.convert                        |    6 +++---
 src/backend/bacon-video-widget-gst-0.10.c |    2 +-
 src/totem-preferences.c                   |   22 +++++++++++-----------
 4 files changed, 20 insertions(+), 20 deletions(-)

commit 8826617a7812fdb74c95e6a190a780f19c5c9dfe
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Thu Aug 19 09:41:16 2010 +0100

    Convert visual-quality to an enum

 data/org.gnome.totem.gschema.xml.in.in |    6 +++---
 src/totem-preferences.c                |    4 +++-
 2 files changed, 6 insertions(+), 4 deletions(-)

commit 90699ee4c30cb214018ae4d8d45b1eecb95a742a
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Thu Aug 19 09:38:08 2010 +0100

    Convert audio-output-type to an enum

 data/org.gnome.totem.gschema.xml.in.in    |    5 ++---
 src/backend/bacon-video-widget-gst-0.10.c |    4 ++--
 2 files changed, 4 insertions(+), 5 deletions(-)

commit db411c5c04f7b4d65ed049c4dc4ed808c81bc12e
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Thu Aug 19 09:35:46 2010 +0100

    Convert connection-speed to an enum

 data/org.gnome.totem.gschema.xml.in.in    |    6 ++--
 src/backend/bacon-video-widget-gst-0.10.c |    4 +-
 src/totem-preferences.c                   |   39 ++++++++++++++++++++++++++++-
 3 files changed, 43 insertions(+), 6 deletions(-)

commit 3985fe548b238dabebeb72cbfd045942af17e8b0
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Wed Aug 18 09:24:34 2010 +0100

    Change "*-path" keys to "*-uri"
    
    They store URIs, not paths.

 data/org.gnome.totem.gschema.xml.in.in           |    4 ++--
 data/totem.convert                               |    4 ++--
 src/plugins/screenshot/totem-screenshot-plugin.c |    4 ++--
 src/totem-uri.c                                  |    6 +++---
 4 files changed, 9 insertions(+), 9 deletions(-)

commit 5b3e8745acbbff909885c4cdee722e1557eae617
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Sat Aug 21 20:14:33 2010 +0100

    Eradicate GConf from configure.in

 configure.in |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

commit 551f901dd0ac62cc438b5b6d8590fef08688482a
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Wed Aug 18 22:59:07 2010 +0100

    Port Python plugins to GSettings

 configure.in                                       |    3 +
 po/POTFILES.in                                     |    3 +
 po/POTFILES.skip                                   |    3 +
 src/plugins/jamendo/Makefile.am                    |   15 ++++-
 src/plugins/jamendo/jamendo.convert                |    3 +
 src/plugins/jamendo/jamendo.py                     |   57 +++++---------------
 ...g.gnome.totem.plugins.jamendo.gschema.xml.in.in |   20 +++++++
 src/plugins/opensubtitles/Makefile.am              |   15 ++++-
 src/plugins/opensubtitles/opensubtitles.convert    |    2 +
 src/plugins/opensubtitles/opensubtitles.py         |   24 ++------
 ...e.totem.plugins.opensubtitles.gschema.xml.in.in |   10 ++++
 src/plugins/pythonconsole/Makefile.am              |   15 ++++-
 ...e.totem.plugins.pythonconsole.gschema.xml.in.in |   10 ++++
 src/plugins/pythonconsole/pythonconsole.convert    |    3 +
 src/plugins/pythonconsole/pythonconsole.py         |    8 ++--
 15 files changed, 116 insertions(+), 75 deletions(-)

commit 84403b142e6c42b8b17a106562e3b919400d8b6c
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Wed Aug 18 09:52:25 2010 +0100

    Port C plugins to GSettings

 configure.in                                       |    6 +-
 po/POTFILES.in                                     |    1 +
 po/POTFILES.skip                                   |    1 +
 src/plugins/bemused/Makefile.am                    |    1 -
 src/plugins/brasero-disc-recorder/Makefile.am      |    1 -
 src/plugins/chapters/Makefile.am                   |    1 -
 src/plugins/chapters/totem-chapters.c              |   40 ++-----
 src/plugins/galago/Makefile.am                     |    1 -
 src/plugins/gromit/Makefile.am                     |    1 -
 src/plugins/lirc/Makefile.am                       |    1 -
 src/plugins/media-player-keys/Makefile.am          |    1 -
 src/plugins/mythtv/Makefile.am                     |   14 +--
 src/plugins/mythtv/totem-mythtv.c                  |   10 --
 src/plugins/ontop/Makefile.am                      |    1 -
 src/plugins/properties/Makefile.am                 |    1 -
 src/plugins/publish/Makefile.am                    |   15 ++-
 ...g.gnome.totem.plugins.publish.gschema.xml.in.in |   28 +++++
 src/plugins/publish/publish.convert                |    3 +
 src/plugins/publish/totem-publish.c                |  121 ++++++--------------
 src/plugins/sample-vala/Makefile.am                |    1 -
 src/plugins/screensaver/Makefile.am                |    1 -
 src/plugins/screensaver/totem-screensaver.c        |   29 +----
 src/plugins/screenshot/Makefile.am                 |    1 -
 src/plugins/screenshot/totem-screenshot-plugin.c   |   43 +++----
 src/plugins/sidebar-test/Makefile.am               |    1 -
 src/plugins/skipto/Makefile.am                     |    1 -
 src/plugins/thumbnail/Makefile.am                  |    1 -
 src/plugins/tracker/Makefile.am                    |    1 -
 src/plugins/youtube/Makefile.am                    |    1 -
 29 files changed, 118 insertions(+), 210 deletions(-)

commit 1248407087d5ee41aa40ce454de0ffc7a823338e
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Wed Aug 18 00:27:11 2010 +0100

    Use GSettings binding for the preferences

 browser-plugin/Makefile.am |    1 -
 data/totem.ui              |    7 --
 lib/Makefile.am            |    1 -
 src/Makefile.am            |    1 -
 src/backend/Makefile.am    |    1 -
 src/totem-preferences.c    |  209 ++++----------------------------------------
 6 files changed, 18 insertions(+), 202 deletions(-)

commit 02883359331a706fb59741be5d697e463aeb37f4
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Wed Aug 18 09:22:06 2010 +0100

    Add an active-plugins key to store the list of active plugins

 data/org.gnome.totem.gschema.xml.in.in |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

commit 9b403af7a43fe953dd6237f69a378086bd05d087
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Wed Aug 18 09:05:52 2010 +0100

    Remove url-handler and thumbnailer schema files
    
    They belong in gsettings-desktop-schemas.

 data/Makefile.am |   21 +--------------
 data/handlers.sh |   47 ----------------------------------
 data/schemas.sh  |   74 ------------------------------------------------------
 3 files changed, 2 insertions(+), 140 deletions(-)

commit 8d65909f1207f6316b2055565b0e94c099c5e916
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Wed Aug 18 00:00:36 2010 +0100

    Port to GSettings

 browser-plugin/totem-plugin-viewer.c      |    1 -
 configure.in                              |   10 +-
 data/Makefile.am                          |   51 +++---
 data/handlers.sh                          |   49 ++---
 data/org.gnome.totem.gschema.xml.in.in    |  120 +++++++++++
 data/schemas.sh                           |   66 +++---
 data/totem.convert                        |   26 +++
 data/totem.schemas.in                     |  332 -----------------------------
 docs/reference/totem-sections.txt         |    2 +-
 po/POTFILES.in                            |    2 +-
 po/POTFILES.skip                          |    1 +
 src/backend/bacon-video-widget-gst-0.10.c |   77 +++----
 src/plugins/totem-dirs.c                  |   11 +-
 src/plugins/totem-plugins-engine.c        |  139 +-----------
 src/totem-interface.c                     |    1 -
 src/totem-object.c                        |    4 +-
 src/totem-options.c                       |    3 +-
 src/totem-options.h                       |    1 -
 src/totem-playlist.c                      |   76 +++----
 src/totem-preferences.c                   |  226 ++++++--------------
 src/totem-private.h                       |    3 +-
 src/totem-uri.c                           |   23 +-
 src/totem.c                               |   20 +-
 src/totem.h                               |    6 +-
 24 files changed, 412 insertions(+), 838 deletions(-)

commit d068d95ac5c21b458c42ced70dae795b5a951b24
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Thu Aug 19 21:33:04 2010 +0100

    Fix naming of visualization methods in BaconVideoWidget

 browser-plugin/totem-plugin-viewer.c      |    2 +-
 docs/reference/totem-sections.txt         |   14 +++---
 src/backend/bacon-video-widget-gst-0.10.c |   72 ++++++++++++++--------------
 src/backend/bacon-video-widget.h          |   36 +++++++--------
 src/totem-preferences.c                   |   14 +++---
 5 files changed, 68 insertions(+), 70 deletions(-)

commit 1d94c7e07bb9675272d92a1056a35566888eab67
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Thu Aug 19 21:19:55 2010 +0100

    Add a visuals-quality property to BaconVideoWidget

 src/backend/bacon-video-widget-gst-0.10.c |   23 ++++++++++++++++++++++-
 1 files changed, 22 insertions(+), 1 deletions(-)

commit 06d6373ebf7a1c802099f83b7470a37d369e9a72
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Thu Aug 19 09:31:09 2010 +0100

    Add a connection-speed property to BaconVideoWidget

 docs/reference/totem-sections.txt         |    3 ++
 src/backend/bacon-video-widget-gst-0.10.c |   23 +++++++++++++++++++-
 src/backend/bacon-video-widget.h          |   32 +++++++++++++++++++++++++++++
 3 files changed, 57 insertions(+), 1 deletions(-)

commit 642b465221413dd8f1ba5e4d081256f153fe23d0
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Thu Aug 19 09:30:47 2010 +0100

    Generate enum types for BaconVideoWidget

 docs/reference/totem-sections.txt |   16 ++++++++++++++++
 src/backend/Makefile.am           |   24 +++++++++++++++++++++++-
 2 files changed, 39 insertions(+), 1 deletions(-)

commit 6d2a201ba1e8f6b189b810fd21c23914a0009c8e
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Wed Aug 18 23:26:56 2010 +0100

    Add a remember-position property to TotemObject

 src/totem-object.c |   19 ++++++++++++++++++-
 1 files changed, 18 insertions(+), 1 deletions(-)

commit c5ba0c0e819067f84b363b31e8d253b14b94ee38
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Wed Aug 18 23:06:33 2010 +0100

    Add a deinterlacing property to BaconVideoWidget

 src/backend/bacon-video-widget-gst-0.10.c |   22 +++++++++++++++++++++-
 1 files changed, 21 insertions(+), 1 deletions(-)

commit 1eac46a08cd345e618886e6fc4778092da44c863
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Wed Aug 18 00:26:57 2010 +0100

    Add an autoload-subtitles property to TotemObject

 src/totem-object.c |   26 ++++++++++++++++++++++++--
 1 files changed, 24 insertions(+), 2 deletions(-)

commit c34e17ebf2621499954df1214f74dd60cebe2199
Author: Philip Withnall <philip@tecnocode.co.uk>
Date:   Wed Aug 18 00:22:45 2010 +0100

    Add an auto-resize property to BaconVideoWidget

 src/backend/bacon-video-widget-gst-0.10.c |   21 ++++++++++++++++++++-
 1 files changed, 20 insertions(+), 1 deletions(-)