After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 625846 - SSL certificate check dialog triggers EAlert warning
SSL certificate check dialog triggers EAlert warning
Status: RESOLVED FIXED
Product: evolution
Classification: Applications
Component: Mailer
unspecified
Other Linux
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2010-08-02 15:42 UTC by Rob Bradford
Modified: 2010-08-02 16:09 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Patch to grab window (1.50 KB, patch)
2010-08-02 15:56 UTC, Rob Bradford
accepted-commit_now Details | Review

Description Rob Bradford 2010-08-02 15:42:58 UTC
The code that triggers this is:

/* The mail daemon won't have a window here, so there's nothing to set
 * as the parent */
 user_message_dialog =
		e_alert_dialog_new_for_args (NULL, error_type, m->prompt, NULL);

Can we call e_shell_get_default and then e_shell_get_active_window ?

(evolution:3739): e-utils-WARNING **: Something called e_alert_dialog_constructed() with a NULL parent window.  This is no longer legal, please fix it.

Breakpoint 1, g_logv (log_domain=0x7f06462922b3 "e-utils", 
    log_level=G_LOG_LEVEL_WARNING, 
    format=0x7f06462922e8 "Something called %s() with a NULL parent window.  This is no longer legal, please fix it.", args1=0x7fff8a8d66d0) at gmessages.c:430
430	  gboolean was_fatal = (log_level & G_LOG_FLAG_FATAL) != 0;
(gdb) bt
  • #0 g_logv
  • #1 g_log
  • #2 e_alert_dialog_constructed
    at e-alert-dialog.c line 147
  • #3 g_object_newv
    at gobject.c line 1375
  • #4 g_object_new_valist
    at gobject.c line 1463
  • #5 g_object_new
    at gobject.c line 1181
  • #6 e_alert_dialog_new
    at e-alert-dialog.c line 276
  • #7 e_alert_dialog_new_for_args
    at e-alert-dialog.c line 292
  • #8 user_message_exec
    at mail-session.c line 378
  • #9 mail_msg_idle_cb
    at mail-mt.c line 442
  • #10 g_idle_dispatch
    at gmain.c line 4224
  • #11 g_main_dispatch
    at gmain.c line 2119
  • #12 g_main_context_dispatch
    at gmain.c line 2672
  • #13 g_main_context_iterate
    at gmain.c line 2750
  • #14 g_main_loop_run
    at gmain.c line 2958
  • #15 IA__gtk_main
    at /tmp/buildd/gtk+2.0-2.20.1/gtk/gtkmain.c line 1219
  • #16 main
    at main.c line 646

Comment 1 Matthew Barnes 2010-08-02 15:53:46 UTC
Yeah, e_shell_get_active_window() would work here.
Comment 2 Rob Bradford 2010-08-02 15:56:06 UTC
Created attachment 166991 [details] [review]
Patch to grab window
Comment 3 Rob Bradford 2010-08-02 15:56:22 UTC
Thanks Matthew, here's the patch.
Comment 4 Matthew Barnes 2010-08-02 16:01:10 UTC
Looks right, go ahead and commit.
Comment 5 Rob Bradford 2010-08-02 16:09:03 UTC
All committed. Thanks!