After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 625805 - uses deprecated g_completion_* functions
uses deprecated g_completion_* functions
Status: RESOLVED FIXED
Product: devhelp
Classification: Applications
Component: General
2.30.x
Other Linux
: Normal normal
: ---
Assigned To: devhelp-maint
devhelp-maint
Depends on:
Blocks:
 
 
Reported: 2010-08-02 08:13 UTC by Martin Pitt
Modified: 2010-08-02 08:19 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Martin Pitt 2010-08-02 08:13:41 UTC
When building dh-search:

#	source='dh-search.c' object='libdevhelp_1_la-dh-search.lo' libtool=yes 
/bin/bash ../libtool  --tag=CC   --mode=compile gcc -DHAVE_CONFIG_H -I. -I..  -I.. -DLOCALEDIR=\""/usr/share/locale"\" -DDATADIR=\""/usr/share"\" -DG_LOG_DOMAIN=\"Devhelp\" -DG_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DG_DISABLE_SINGLE_INCLUDES -DGDK_PIXBUF_DISABLE_SINGLE_INCLUDES -DGTK_DISABLE_SINGLE_INCLUDES -Wall -Wmissing-prototypes     -pthread -DORBIT2=1 -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/libwnck-1.0 -I/usr/include/startup-notification-1.0 -I/usr/include/webkit-1.0 -I/usr/include/libsoup-2.4 -I/usr/include/libxml2   -g -O2 -g -Wall -O2 -c -o libdevhelp_1_la-dh-search.lo `test -f 'dh-search.c' || echo './'`dh-search.c
libtool: compile:  gcc -DHAVE_CONFIG_H -I. -I.. -I.. -DLOCALEDIR=\"/usr/share/locale\" -DDATADIR=\"/usr/share\" -DG_LOG_DOMAIN=\"Devhelp\" -DG_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DG_DISABLE_SINGLE_INCLUDES -DGDK_PIXBUF_DISABLE_SINGLE_INCLUDES -DGTK_DISABLE_SINGLE_INCLUDES -Wall -Wmissing-prototypes -pthread -DORBIT2=1 -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/gio-unix-2.0/ -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pixman-1 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/gconf/2 -I/usr/include/orbit-2.0 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/libwnck-1.0 -I/usr/include/startup-notification-1.0 -I/usr/include/webkit-1.0 -I/usr/include/libsoup-2.4 -I/usr/include/libxml2 -g -O2 -g -Wall -O2 -c dh-search.c  -fPIC -DPIC -o .libs/libdevhelp_1_la-dh-search.o
dh-search.c: In function 'search_finalize':
dh-search.c:95: warning: implicit declaration of function 'g_completion_free'
dh-search.c: In function 'dh_search_init':
dh-search.c:128: warning: implicit declaration of function 'g_completion_new'
dh-search.c:129: warning: assignment makes pointer from integer without a cast
dh-search.c: In function 'search_complete_idle':
dh-search.c:394: warning: implicit declaration of function 'g_completion_complete'
dh-search.c:394: warning: assignment makes pointer from integer without a cast
Function `g_completion_complete' implicitly converted to pointer at dh-search.c:394
dh-search.c: In function 'dh_search_new':
dh-search.c:654: warning: implicit declaration of function 'g_completion_add_items'

This will likely cause segfaults on architectures where the size of
a pointer is greater than the size of an integer, such as ia64 and amd64.
Comment 1 Martin Pitt 2010-08-02 08:17:17 UTC
Ah, that's because these are now marked as G_DISABLE_DEPRECATED
Comment 2 Martin Pitt 2010-08-02 08:19:17 UTC
Sorry for the noise, this was fixed in HEAD in commit a526f7ed3f36e463d9f22782865a6468c5aec30b .