After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 625780 - Not attaching to minimized window
Not attaching to minimized window
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Chat
2.30.x
Other Linux
: Normal major
: ---
Assigned To: empathy-maint
: 625674 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-08-01 21:27 UTC by Michael Monreal
Modified: 2010-10-22 12:19 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
proposed fix (1.85 KB, patch)
2010-09-17 12:31 UTC, Vitaly Minko
none Details | Review

Description Michael Monreal 2010-08-01 21:27:46 UTC
Start a chat with someone and minimize the window. Now, if someone else writes you an IM or you start another chat, the new chat is not created in the existing window (with the tabbed chat setting on)
Comment 1 Guillaume Desmottes 2010-08-02 10:15:16 UTC
*** Bug 625674 has been marked as a duplicate of this bug. ***
Comment 2 Guillaume Desmottes 2010-08-02 10:15:41 UTC
Yeah that's because our code doesn't detect there is a window when it's minimized.
Comment 3 Vitaly Minko 2010-09-17 12:31:50 UTC
Created attachment 170479 [details] [review]
proposed fix

The proposed fix is attached.
Comment 4 Guillaume Desmottes 2010-09-17 12:50:50 UTC
Humm yeah that makes sense as after we call empathy_window_present_with_time() which will display the window and move it to the right display if needed.
A bit late for 2.32.0 but we could consider merging it for 2.31.1

Xavier: you wrote this code, can you think of any side effect this change could introduce?
Comment 5 Vitaly Minko 2010-10-21 15:19:42 UTC
>A bit late for 2.32.0 but we could consider merging it for 2.31.1

I don't understand why you think it's obsolete for 2.32. The issue is still reproducible and the patch still fixes the issue.

It's now available here:
repo: git://vminko.org/empathy
branch: fix-625780
Comment 6 Guillaume Desmottes 2010-10-22 12:19:03 UTC
I'm afraid to introduce regression in the stable branch.  I merged your branch to master though; thanks!

This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.