After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 625752 - Use _async suffix to make API more readable
Use _async suffix to make API more readable
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Contacts
unspecified
Other Linux
: Normal normal
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2010-08-01 10:43 UTC by Rob Bradford
Modified: 2010-08-02 12:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
e-d-s patch (47.67 KB, patch)
2010-08-01 10:43 UTC, Rob Bradford 		accepted-commit_now Details | Review
evolution patch (25.12 KB, patch)
2010-08-01 10:43 UTC, Rob Bradford 		accepted-commit_now Details | Review

Description Rob Bradford 2010-08-01 10:43:21 UTC 
Created attachment 166915 [details] [review]
e-d-s patch

The _ex suffix for the new error reporting functions is a little bit unwieldly. How about _async as a suffix e.g.:

e.g. e_book_open_async rather than e_book_async_open_ex compared to
e_book_async_open (old)

I've prepared patches for this for both eds and evolution.

They are attached but are also present in the branch rbradford-async-rename for ease of merging.

I've tested evo master against this change and the eds test suite (leading to the previous double free fix.. :-)
Comment 1 Rob Bradford 2010-08-01 10:43:48 UTC 
Created attachment 166916 [details] [review]
evolution patch
Comment 2 Matthew Barnes 2010-08-01 11:02:44 UTC 
+1
Comment 3 Ross Burton 2010-08-02 11:10:47 UTC 
Yes yes yes.

Please commit with wild abandonment.
Comment 4 Rob Bradford 2010-08-02 12:33:59 UTC 
Committed!