After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 625745 - Tabs not displayed in chat text in theme
Tabs not displayed in chat text in theme
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Chat
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks:
 
 
Reported: 2010-08-01 07:28 UTC by Stef Walter
Modified: 2011-08-29 10:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Screenshot of chat text missing tabs. (18.35 KB, image/png)
2010-08-01 07:28 UTC, Stef Walter 		  Details
proposed fix (664 bytes, patch)
2010-10-05 10:29 UTC, Vitaly Minko 		reviewed Details | Review

Description Stef Walter 2010-08-01 07:28:55 UTC 
Created attachment 166909 [details]
Screenshot of chat text missing tabs.

I was chatting someone with the contents of my ~/.ssh/config and noticed that tabs are not displayed correctly. Screenshot attached.

Below is the original text equivalent to what's in the screenshot:


Host ??.xxx.net
	ForwardAgent yes
	Port 1222
	User stef

Host *.test.xxx.net
	ForwardAgent yes
	Port 1222
	User stef

Host *.test.xxx.net
	ForwardAgent yes
	Port 1222
	User stef
Comment 1 Guillaume Desmottes 2010-08-02 10:12:34 UTC 
That's because Adium themes render the message using HTML which doesn't display tabs.

Kov: any smart idea about how we could display that using webkit?
Comment 2 Guillaume Desmottes 2010-08-02 13:29:45 UTC 
Crazy idea: maybe we could use the verbatim markups when we the messages contains more than one line?
Comment 3 Stef Walter 2010-08-02 15:19:20 UTC 
<pre> seems to make sense. It also solves the problem of multiple spaces being collapsed by default by HTML.

Or you could just use CSS like:

white-space: pre; 

for all messages
Comment 4 Vitaly Minko 2010-10-05 10:29:37 UTC 
Created attachment 171750 [details] [review]
proposed fix
Comment 5 Guillaume Desmottes 2010-10-06 10:39:36 UTC 
Review of attachment 171750 [details] [review]:

Looks good to me but I prefer to check with Xavier before merging it.
Comment 6 Guillaume Desmottes 2010-11-11 12:33:32 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.