GNOME Bugzilla – Bug 625675
freenode should be the default irc network when creating an irc account
Last modified: 2010-08-11 08:44:38 UTC
freenode is the most used IRC network (maybe GIMPnet too). support for most linux distribution is on freenode e.g. #ubuntu #fedora #meego etc so it will become easier for users when creating an IRC account. also reported as a papercut: https://bugs.launchpad.net/hundredpapercuts/+bug/569289
Created attachment 166868 [details] [review] Patch to fix bug This is the patch, sans debian stuff.
(In reply to comment #0) > > also reported as a papercut: > https://bugs.launchpad.net/hundredpapercuts/+bug/569289 Just to be clear on the papercut status of the bug, Since Ubuntu channels are on freenode, this is reasonable distro-level change.[ Not trying to force a distro setting on gnome :) ] We had done this earlier for Pidgin too[changed the default network in Ubuntu]. However , it is odd that there is no default network already setup, and Bilal's patch seems to be in the right direction, and allows distros to change the default network easier.
Review of attachment 166868 [details] [review]: I'm wondering if, as a GNOME project, we shouldn't default to GIMPNet instead? ::: libempathy-gtk/empathy-account-widget-irc.c @@ +417,3 @@ + if (network == NULL) + { + const gchar *freenodeserver = (const gchar*)"chat.freenode.net"; No need to cast. @@ +419,3 @@ + const gchar *freenodeserver = (const gchar*)"chat.freenode.net"; + network = empathy_irc_network_manager_find_network_by_address ( + settings->network_manager, freenodeserver); I'd #define a DEFAULT_IRC_NETWORK so no need to create an extra var.
The patch has been accepted in Ubuntu. I agree with what Guillaume said. It would be definitely better to have a DEFAULT_IRC_NETWORK variable.
Created attachment 167481 [details] [review] Improved patch Cassidy, This patch is an improved version of the previous patch, and I have taken into account the problems pointed out by you. Thanks for the review!
Thanks for the patch. I commited it with the following changes: - default to GimpNet isntead of freenode as Empathy is a GNOME project. Distro can easily change it by patching one line. - Coding style fixes. commit 105ef42a1690c3c092879995767584b640741e12 Author: Bilal Akhtar <bilalakhtar96@yahoo.com> Date: Wed Aug 11 10:43:20 2010 +0200 Use GimpNet as default IRC network (#625675) This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.