After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 625566 - Delete xmp sidecar when deleting Photo completely
Delete xmp sidecar when deleting Photo completely
Status: RESOLVED WONTFIX
Product: f-spot
Classification: Other
Component: General
GIT
Other Linux
: Normal normal
: ---
Assigned To: F-spot maintainers
F-spot maintainers
gnome[unmaintained]
Depends on:
Blocks:
 
 
Reported: 2010-07-29 10:21 UTC by Paul Wellner Bou
Modified: 2018-07-01 09:04 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Delete xmp if original version is deleted from drive (1.85 KB, patch)
2010-07-29 11:06 UTC, Paul Wellner Bou
reviewed Details | Review
Delete xmp if original version (last remaining version) is deleted from drive (1.23 KB, patch)
2010-08-02 20:23 UTC, Paul Wellner Bou
none Details | Review
Deletes "useless" xmp-sidecar-files (1.29 KB, text/x-sh)
2011-06-29 23:12 UTC, gnome.org
  Details
[PATCH] Delete xmp sidecar when deleting Photo completely -- updated to latest git (1.60 KB, patch)
2012-10-10 02:07 UTC, Arun Persaud
none Details | Review

Description Paul Wellner Bou 2010-07-29 10:21:37 UTC
The xmp sidecar files are not removed when a photo is deleted completely.
Comment 1 Paul Wellner Bou 2010-07-29 11:06:54 UTC
Created attachment 166766 [details] [review]
Delete xmp if original version is deleted from drive
Comment 2 Paul Wellner Bou 2010-07-29 11:10:40 UTC
Review of attachment 166766 [details] [review]:

The crappy formatting is because the original file had tabs instead of spaces. Sorry.
Comment 3 Ruben Vermeersch 2010-08-02 13:21:37 UTC
Review of attachment 166766 [details] [review]:

::: src/Core/Photo.cs
@@ +293,3 @@
+                }
+
+                if(remove_original && version_id == OriginalVersionId) {

Missing a space here between the if and the bracket.

Why only delete when deleting the original version?
Comment 4 Paul Wellner Bou 2010-08-02 15:51:18 UTC
Because it shouldn't be removed deleting only one version, while others of this photo are kept. This will be the next step, when we have unique xmp files.for each file, not for each basename.
Comment 5 Paul Wellner Bou 2010-08-02 20:23:28 UTC
Created attachment 167011 [details] [review]
Delete xmp if original version (last remaining version) is deleted from drive

https://bugzilla.gnome.org/show_bug.cgi?id=625336
Comment 6 Paul Wellner Bou 2010-08-02 20:24:28 UTC
Fixed the formatting.

Normally the original version can not be deleted as version. It can only be deleted deleting the entire Photo.
Comment 7 gnome.org 2011-06-29 23:12:03 UTC
Created attachment 190970 [details]
Deletes "useless" xmp-sidecar-files

Hi, 

For anyone stuck with a lot of "useless" xmp-files:

I attached a little bash-script to this bug-report, that will delete all the xmp-files which don't have a corresponding .NEF, .jpg, .JPG or .jpeg file in specified folder(s).

It worked for me, but USE IT AT YOUR OWN RISK!!

Cheers,
Don
Comment 8 gnome.org 2011-06-30 14:27:23 UTC
PS: the script works for Nikon-Cameras (files with the following naming pattern DSC_1234.JPG / DSC_1234.NEF ). Modify the script for other file-name-patterns.
Comment 9 Arun Persaud 2012-10-10 02:07:09 UTC
Created attachment 226152 [details] [review]
[PATCH] Delete xmp sidecar when deleting Photo completely -- updated to latest git

updated for git commit 5b6706b5446be47ba91e289fc32ec3e41b1cdb89 on master
Comment 10 André Klapper 2018-07-01 09:04:11 UTC
f-spot is not under active development anymore, has not seen code changes for five years, and saw its last tarball release in the year 2010.
Its codebase has been archived: https://gitlab.gnome.org/Archive/f-spot/commits/master

Closing this report as WONTFIX as part of Bugzilla Housekeeping to reflect reality. Please feel free to reopen this ticket (or rather transfer the project to GNOME Gitlab, as GNOME Bugzilla is deprecated) if anyone takes the responsibility for active development again.