After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 625558 - [basevideoencoder] [vp8] encoder timestamps are wrong when there are gaps
[basevideoencoder] [vp8] encoder timestamps are wrong when there are gaps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Linux
: Normal normal
: 0.10.21
Assigned To: GStreamer Maintainers
GStreamer Maintainers
: 627971 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-07-29 08:56 UTC by Zaheer Abbas Merali
Modified: 2010-12-01 11:03 UTC
See Also:
GNOME target: ---
GNOME version: ---


Description Zaheer Abbas Merali 2010-07-29 08:56:40 UTC 
If there is a gap between segment start and timestamp of first incoming buffer, then timestamp of outgoing buffer is wrong.

If there are any gaps elsewhere, say there are dropped frames in input, then timestamp is also wrong on output buffer.

It looks like the incoming buffer timestamp is disregarded and just an incrementing frame number counter with framerate taken into account is used.

Maybe the frame number should be computed not by incrementing but by using the incoming buffer timestamp.
Comment 1 Zaheer Abbas Merali 2010-10-10 13:59:45 UTC 
*** Bug 627971 has been marked as a duplicate of this bug. ***
Comment 2 David Schleef 2010-12-01 02:35:21 UTC 
commit 01574dc012495522170a97c1902ca18e6038785e
Author: David Schleef <ds@schleef.org>
Date:   Mon Nov 29 20:21:31 2010 -0800

    vp8enc: Don't override timestamps set by base class
    
    Because the base class does it correctly.
    Fixes: #635720, #625558.