After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 625519 - FORTRAN: Incorrect recognition of an argument name starting with a reserved word
FORTRAN: Incorrect recognition of an argument name starting with a reserved word
Status: VERIFIED FIXED
Product: doxygen
Classification: Other
Component: general
1.7.1
Other Windows
: Normal normal
: ---
Assigned To: Dimitri van Heesch
Dimitri van Heesch
: 630658 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-07-28 19:37 UTC by albert
Modified: 2011-11-01 11:31 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Source code (62 bytes, application/octet-stream)
2010-07-28 19:37 UTC, albert
  Details
HTML output (2.45 KB, text/html)
2010-07-28 19:38 UTC, albert
  Details
Attribute names as start of variable names are ignored (1.31 KB, patch)
2010-11-14 20:04 UTC, albert
none Details | Review
Attribute names as start of variable names are ignored (corrected) (1.39 KB, patch)
2010-12-08 18:27 UTC, albert
none Details | Review
Attribute names as start of variable names are ignored (corrected) (1.39 KB, patch)
2010-12-08 18:32 UTC, albert
none Details | Review
Attribute names as start of variable names are ignored (corrected 3) (1.41 KB, patch)
2010-12-09 19:41 UTC, albert
none Details | Review

Description albert 2010-07-28 19:37:28 UTC
Created attachment 166736 [details]
Source code

In case an argument starts with a reserved word (eg argument ExternalName) Doxygen does not recognise this properly and no data type is placed in the documentation (see attachment with source code and html output)
Comment 1 albert 2010-07-28 19:38:11 UTC
Created attachment 166737 [details]
HTML output
Comment 2 albert 2010-07-28 19:40:47 UTC
Some small investigations lead to the fact that the lexical scanner (fortranscanner.l) does recognize the reserved word External in the argument list and does not recognizes that it is not the word ExternalName.
Changing the word to MyExetrnalName also gives the correct output, so it looks like that the end of the word is nor recognized correctly.
I have hardly any experience with lex (and yacc) but shouldn't read the line (222) with the ATTR_SPEC definition read EXTERNAL\> instead of EXTERNAL for this keyword. The same accounts of course for all other reserved names.
Comment 3 albert 2010-11-14 18:03:39 UTC
*** Bug 630658 has been marked as a duplicate of this bug. ***
Comment 4 albert 2010-11-14 20:04:50 UTC
Created attachment 174457 [details] [review]
Attribute names as start of variable names are ignored

Attribute names as start of variable names are ignored by checking the next character in the input stream.
Comment 5 albert 2010-12-08 18:27:37 UTC
Created attachment 176080 [details] [review]
Attribute names as start of variable names are ignored (corrected)

Correction to the previous patch. The unput had some side effects on yytext.
Comment 6 albert 2010-12-08 18:32:45 UTC
Created attachment 176081 [details] [review]
Attribute names as start of variable names are ignored (corrected)

Correction to the previous patch. The unput had some side effects on yytext.
Comment 7 albert 2010-12-08 18:35:18 UTC
Please ignore Comment 5 with patch, is identical to Comment 6 (connection to bugzilla was very slow)
Comment 8 albert 2010-12-09 19:41:02 UTC
Created attachment 176148 [details] [review]
Attribute names as start of variable names are ignored (corrected 3)

Had to take UNDERSCORE also into account
Comment 9 Dimitri van Heesch 2011-01-04 09:03:01 UTC
I'll include this patch in the next subversion update.
Comment 10 Dimitri van Heesch 2011-03-28 14:19:05 UTC
This bug was previously marked ASSIGNED, which means it should be fixed in
doxygen version 1.7.4. Please verify if this is indeed the case. Reopen the
bug if you think it is not fixed and please include any additional information
that you think can be relevant.
Comment 11 albert 2011-11-01 11:31:05 UTC
Reserved words as part of names are recognized properly.