GNOME Bugzilla – Bug 625496
qtmux - misc fix on btrt box
Last modified: 2010-07-28 15:28:43 UTC
Two small patches. One fix the ordering of bitrates. The second will make use of the caps bitrate if there was not tag bitrate events before.
Created attachment 166716 [details] [review] qtmux: btrt - max bitrate before average
Created attachment 166717 [details] [review] qtmux: use caps bitrate at last chance
Review of attachment 166716 [details] [review]: Where have you seen that the max is the first?
Ä0亨1 (In reply to comment #3) > Review of attachment 166716 [details] [review]: > > Where have you seen that the max is the first? 8.5.2.2 BitRateBox, page 27 (37 in evince) of ISO document part 12 from 2008.
Check this commit in -good 8aed3176ce65a1963d1b2bea8b9ed110714ca4e2
so it makes sense to fix it in gstqtmux too no?
You were right, the patch in qtdemux was wrong :) Pushed. Thanks! commit 691901da51799cb04d17ed9ba94619bc7fd61f73 Author: Marc-André Lureau <mlureau@flumotion.com> Date: Wed Jul 28 16:15:53 2010 +0200 qtmux: use caps bitrate at last chance If we didn't get the stream's bitrate from one of the atoms, try getting it from the caps as a last resort. https://bugzilla.gnome.org/show_bug.cgi?id=625496 commit 2e17f7cbf72014b7a5e2a5b115039213775af1b1 Author: Marc-André Lureau <mlureau@flumotion.com> Date: Wed Jul 28 16:12:11 2010 +0200 qtmux: btrt - max bitrate before average According to iso base media file format, the max bitrate is before the avg https://bugzilla.gnome.org/show_bug.cgi?id=625496