After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 625326 - Test test_signal.TestCMarshaller.testTest4 fails with d == 1.78
Test test_signal.TestCMarshaller.testTest4 fails with d == 1.78
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2010-07-26 15:20 UTC by Simon van der Linden
Modified: 2010-07-26 15:54 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Don't use == to compare doubles, use <= and =>. (919 bytes, patch)
2010-07-26 15:39 UTC, Simon van der Linden 		committed Details | Review

Description Simon van der Linden 2010-07-26 15:20:00 UTC 
testTest4 (test_signal.TestCMarshaller) ... 
** CRITICAL **: test4_callback: assertion `d == 1.78' failed

d is a double and should not be compared with ==, but <= and => to avoid precision differences.
Comment 1 Simon van der Linden 2010-07-26 15:39:26 UTC 
Created attachment 166594 [details] [review]
Don't use == to compare doubles, use <= and =>.

This avoids inequality due to small precisions difference.
Comment 2 Tomeu Vizoso 2010-07-26 15:54:31 UTC 
Thanks!

Attachment 166594 [details] pushed as 7e9cbd5 - Don't use == to compare doubles, use <= and =>.