After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 625273 - Insert Font and font-size into the Texteditor's Menubar
Insert Font and font-size into the Texteditor's Menubar
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Tools
2.7.1
Other All
: High minor
: 2.8
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2010-07-26 04:14 UTC by aprz
Modified: 2011-03-18 21:17 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description aprz 2010-07-26 04:14:53 UTC
If you didn't change the text's font or font-size, nothing is displayed in the menubar right next to the Text-tool. Maybe it would be a good Idea to insert the default values.
Comment 1 Michael Natterer 2010-09-07 11:42:27 UTC
This is planned anyway.
Comment 2 LightningIsMyName 2010-10-11 23:59:32 UTC
Actually, we should implement all the text editing features which are available in the on-canvas editor, inside the editor dialog. And we should also implement some features which are only available using the editor, so that they will be available using the on-canvas editor (importing text, setting LTR or RTL).

Suggestion - implement all the text editing features (which can applied to regions of the text) in both, and move all the properties which apply to the entire text to the tool-options dialog (such as importing). Please see also bug report Bug 631934 about the future behaviour of text attributes in gimp.

Changing the description accordingly.
Comment 3 Martin Nordholts 2010-10-12 05:11:51 UTC
Remind me please, why do we need the editor dialog at all?
Comment 4 Sven Neumann 2010-10-12 21:13:52 UTC
Indeed, why can't we just drop the editor window now that the onscreen editor has all the features? We used to keep the editor window around for features such as copy-n-paste, but isn't this all supported on the onscreen editor now?
Comment 5 LightningIsMyName 2010-10-12 23:32:02 UTC
The editor has several features which needs to implemented in the on-canvas version before continuing (Can't check these right now, but I believe they are not present):

1. Inserting special unicode control characters - this is available by right clicking the entry in the editor dialog, while I don't remember seeing it in the on-canvas version
2. According to the official docs, it is possible to insert unicode characters to the text input in the dialog, by clicking Ctrl+Shift+U and then typing the hexadecimal code of the character. I don't think the on-canvas editor supports this.
3. Finally, the editor dialog allows to chose something called input method (by right clicking the input widget). I don't really know what this is, but it has to be supported in the on-canvas editor before discrading the dialog.

In addition to the technical reasons I listed, sometimes it's easier to have a dialog to edit the text instead of zooming out and panning the image (in cases of long text's and/or big font size).
I think that if we implement the 3 things above, it should be OK to discard the dialog editor, but it would be nice if we can find some good alternate way to edit large text (or optionally, allow formatted text to be exported and imported, so that editing long text won't have to be done in gimp)
Comment 6 Martin Nordholts 2010-10-13 05:13:42 UTC
1. Use Ctrl+Shift+u+[code] like everywhere in GTK+
2. See above, works for me
3. Not sure we need it, isn't it enough to manage this in global GNOME preferences?

In any case, if 3 is needed, the solution is to add that capability to the on-canvas text editor, not duplicating the on-canvas editor in the dialog editor

I will create a new bug report for 2.8 reminding us to get rid of the dialog text editor.
Comment 7 Martin Nordholts 2010-10-13 05:17:59 UTC
Oh and regarding 3, I get an Input Method menu by right-clicking on the canvas with the Text Tool active
Comment 8 Martin Nordholts 2010-10-13 05:19:48 UTC
For cross-reference:
Bug 632027 - Remove Text Tool "GIMP Text Editor"
Comment 9 Martin Nordholts 2011-03-14 07:54:47 UTC
Not critical for 2.8, but still should be fixed quite soon IMO. Moving to 2.10
Comment 10 Michael Natterer 2011-03-18 19:52:30 UTC
Guys, you completely hijacked this bug report, the reporter meant
something entirely different:

When the cursor is not on any tag that defines font, size, color etc,
the respective widgets in GimpTextStyleEditor are simply empty,
instead of displaying the default values from the text options.

That's what I meant will be fixed when I said "This is planned anyway".

The text UI is pretty much one big mess without this, and I'm going
to fix it for 2.8.
Comment 11 Michael Natterer 2011-03-18 21:17:16 UTC
Done:

commit 140c9aae91e2671a02e1b146d69715b39cbeb145
Author: Michael Natterer <mitch@gimp.org>
Date:   Fri Mar 18 22:13:34 2011 +0100

    Bug 625273 - Insert Font and font-size into the Texteditor's Menubar
    
    If the cursor position (or the current selection), doesn't contain any
    font, font-size or color tags, display the default values from the
    GimpText object instead of "nothing". Still display nothing if the
    selection contains different fonts, sizes or colors.

 app/widgets/gimptextstyleeditor.c |  209 ++++++++++++++++++++++++++-----------
 1 files changed, 148 insertions(+), 61 deletions(-)