GNOME Bugzilla – Bug 625248
[enh] migrate to GtkBuilder
Last modified: 2010-11-28 23:54:35 UTC
This plugin is still using glade.
All of them are so far... we do need to convert. Now that we've branched for 0.9, we can do this.
I have finished a patch for it but unfortunately at the moment I cannot build NetworkManager because of bug 623952 and so, I have not tested it. I get: /home/pablo/opt/gnome2/lib/libgio-2.0.so: undefined reference to `g_variant_new_bytestring' /home/pablo/opt/gnome2/lib/libgio-2.0.so: undefined reference to `g_variant_new_bytestring_array' /home/pablo/opt/gnome2/lib/libgio-2.0.so: undefined reference to `g_variant_get_bytestring' any idea?
http://live.gnome.org/GnomeGoals/RemoveLibGladeUseGtkBuilder
(In reply to comment #2) > I have finished a patch for it but unfortunately at the moment I cannot build > NetworkManager because of bug 623952 and so, I have not tested it. > > I get: > /home/pablo/opt/gnome2/lib/libgio-2.0.so: undefined reference to > `g_variant_new_bytestring' > /home/pablo/opt/gnome2/lib/libgio-2.0.so: undefined reference to > `g_variant_new_bytestring_array' > /home/pablo/opt/gnome2/lib/libgio-2.0.so: undefined reference to > `g_variant_get_bytestring' > > any idea? These are glib issues; seems you have a mismatched glib install or need to update the glib pkgconfig file to include whatever lib the GVariant stuff is in? GVariant is pretty new and that's a core glib thing now, so this indicates a link error in glib and not in NM.
*** Bug 589500 has been marked as a duplicate of this bug. ***
Thanks for picking this up too! It's something that's needed to happen for a while.
Created attachment 167293 [details] [review] 0001-Migrate-from-Glade-to-GtkBuilder.patch Here is a huge patch to migrate network-manager-applet to gtkbuilder. I have tested it and everything seem to work fine :) The only things I have doubts is about using gtk_widget_unparent() to solve some issues I found when trying to pack with gtk_container_add() a widget drawn and taken from an .ui file (which already has a parent). According to the documentation it should only be called by widget implementations. Comments are welcome.
Not less important: August 16th begins UI freeze
Created attachment 167294 [details] [review] Migrate openvpn plugin to gtkbuilder This patch migrates the network-manager-openvpn to gtkbuilder. Tested and it's OK for me.
Created attachment 167295 [details] [review] Migrate openvpn plugin to gtkbuilder Forgot to add the new .ui file in previous patch
(In reply to comment #8) > Not less important: August 16th begins UI freeze But only for modules that are included in GNOME. N-M is not.
(In reply to comment #11) > (In reply to comment #8) > > Not less important: August 16th begins UI freeze > > But only for modules that are included in GNOME. N-M is not. Oh, that's true. Thanks for clarifying
Created attachment 167321 [details] [review] Migrate applet to gtkbuilder Forgot to add another gtk_widget_unparent() in previous patch
Thanks again, hope to review and push these by the weekend.
nm-openvpn: 880e1d105babeac8777a30348f46a28a7a39c3b8 (master) 2ce3f5254d3e7bfe4cf5c87a7959ff928892f578 (0.8.x) nm-applet: 32f66acbc06dfd645aa41f2bf14d197f414fd163 (master) f706aaa4c36c21bd663e08707dc9412c1732f854 (0.8.x) thanks again!
Great!! :-D