GNOME Bugzilla – Bug 625138
[dshowvideosrc] Don't use a range in the caps if min==max
Last modified: 2010-08-14 13:15:09 UTC
Created attachment 166460 [details] [review] 0001-dshowvideosrc-Don-t-make-a-range-if-min-max If we have fixed values, trying to make a range results on a error and the caps will be missing the fields 'height', 'width' and 'framerate', which doesn't match the pad template.
Created attachment 166461 [details] [review] Fix commit author (previous was void)
Hi, Thx for reporting and the patch. I have 2 questions: ** If we a fixed width as 10, why having "width=(int)[ 10, 10 ]" results on a error ? Anyway, having "width=(int)10" would be better. ** You wrote: after executing "if (min_w = max_w)", then min_w will be equal to max_w (and only False if max_w is equal to 0). Is it what you want ? (should be "==" instead of "=" ? Julien
(In reply to comment #2) > Hi, > > Thx for reporting and the patch. > > I have 2 questions: > > ** If we a fixed width as 10, why having "width=(int)[ 10, 10 ]" results on a > error ? > Anyway, having "width=(int)10" would be better. The start must be smaller than the range stop http://cgit.freedesktop.org/gstreamer/gstreamer/tree/gst/gstvalue.c#n785 > > ** You wrote: after executing "if (min_w = max_w)", then min_w will be equal to > max_w (and only False if max_w is equal to 0). Is it what you want ? (should be > "==" instead of "=" ? That's a very stupid typo from my side :) > > Julien
Created attachment 166466 [details] [review] Fix values comparison (replace min=max with min==max)
commit 0390f0d765545dcf4669b1e9592a133b223f6a8a Author: Andoni Morales <ylatuya@gmail.com> Date: Thu Jul 29 16:08:03 2010 +0200 dshowvideosrc: don't make a range if min==max Fixes bug #625138