After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 625076 - neonhttpsrc: add connect-timeout and read-timeout properties
neonhttpsrc: add connect-timeout and read-timeout properties
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-bad
git master
Other Windows
: Immediate blocker
: 0.10.20
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-07-22 22:53 UTC by David Hoyt
Modified: 2010-08-30 13:21 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Adds connect and read timeout properties (3.47 KB, patch)
2010-07-22 22:53 UTC, David Hoyt
committed Details | Review
configure: Bump neon requirement to 0.27.0 (898 bytes, patch)
2010-08-27 06:32 UTC, Jan Schmidt
committed Details | Review

Description David Hoyt 2010-07-22 22:53:04 UTC
Created attachment 166418 [details] [review]
Adds connect and read timeout properties

The attached patch adds connect and read timeout properties to neonhttpsrc.
Comment 1 Tim-Philipp Müller 2010-08-06 10:11:18 UTC
> --- gst/neon/gstneonhttpsrc.c	(revision 766)
> +++ gst/neon/gstneonhttpsrc.c	(working copy)

Seriously? I have to adjust paths as well now?

David, is it really so hard to set up git in windows that you can't submit patches in proper git format-patch format like everyone else? If you use SVN or CVS, that's up to you of course, but you can easily copy the patches over and re-committed them locally in a git branch and then use git-format...


 commit f724428e073df3c3fc7c50407efe365233cdc030
 Author: David Hoyt <dhoyt@llnl.gov>
 Date:   Fri Aug 6 11:04:57 2010 +0100

    neonhttpsrc: add connect-timeout and read-timeout properties
    
    https://bugzilla.gnome.org/show_bug.cgi?id=625076
Comment 2 Tim-Philipp Müller 2010-08-06 10:12:40 UTC
Comment on attachment 166418 [details] [review]
Adds connect and read timeout properties

Committed, grudgingly.
Comment 3 David Hoyt 2010-08-06 17:31:32 UTC
Sorry about the paths - that was unintentional.

As for using git -- I haven't had the chance to learn it yet with all the other things on my to-do list. Once I learn it and can parse what you said, I'd be happy to do as requested.

Again, I apologize for the inconvenience. If you prefer, you can leave the patches be until I get the opportunity to learn git and put them in the right format. I just don't want to forget about them since they may still be beneficial to the community in some small sense.
Comment 4 David Schleef 2010-08-27 05:33:59 UTC
This change causes:

(gst-plugin-scanner:4906): GStreamer-WARNING **: Failed to load plugin '/usr/local/lib/gstreamer-0.10/libgstneonhttpsrc.so': /usr/local/lib/gstreamer-0.10/libgstneonhttpsrc.so: undefined symbol: ne_set_connect_timeout

Either this needs to be reversed or we need to bump the required neon version.

I appear to have 0.26.4-4 (ubuntu).
Comment 5 Jan Schmidt 2010-08-27 06:25:07 UTC
ne_set_connect_timeout() was added in libneon 0.27, it seems, which is available in Lucid as neon27. I propose we just bump the requirement, since that was released in 2007.
Comment 6 Jan Schmidt 2010-08-27 06:32:04 UTC
Created attachment 168859 [details] [review]
configure: Bump neon requirement to 0.27.0

Needed in order to have ne_set_connect_timeout

Fixes bug #625076
Comment 7 Sebastian Dröge (slomo) 2010-08-30 13:21:41 UTC
commit dab76bc68ef49d0a4c77809f049d90def8aee083
Author: Jan Schmidt <thaytan@noraisin.net>
Date:   Fri Aug 27 15:49:39 2010 +1000

    configure: Bump neon requirement to 0.27.0
    
    Needed in order to have ne_set_connect_timeout
    
    Fixes bug #625076