After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 625050 - Add override for GLib.Variant.new_tuple
Add override for GLib.Variant.new_tuple
Status: RESOLVED FIXED
Product: pygobject
Classification: Bindings
Component: introspection
unspecified
Other All
: Normal normal
: ---
Assigned To: Nobody's working on this now (help wanted and appreciated)
Python bindings maintainers
Depends on:
Blocks:
 
 
Reported: 2010-07-22 17:40 UTC by Tomeu Vizoso
Modified: 2010-09-10 08:55 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add override for GLib.Variant.new_tuple (7.86 KB, patch)
2010-07-22 17:40 UTC, Tomeu Vizoso
none Details | Review
Add override for GLib.Variant.new_tuple (6.09 KB, patch)
2010-09-08 09:10 UTC, Tomeu Vizoso
committed Details | Review

Description Tomeu Vizoso 2010-07-22 17:40:01 UTC
g_variant_new_tuple is not introspectable
Comment 1 Tomeu Vizoso 2010-07-22 17:40:03 UTC
Created attachment 166408 [details] [review]
Add override for GLib.Variant.new_tuple

* gi/gimodule.c: Add _wrap_pyg_variant_new_tuple
* gi/overrides/GLib.py: Override Variant.new_tuple and Variant.get_string
* gi/pygi-type.[hc]: split _pygi_type_import_by_name out from
  _pygi_type_import_by_gi_info
* gi/types.py: Never override gobject.TYPE_NONE
* tests/test_everything.py: Add tests for GVariant tuples
Comment 2 johnp 2010-07-27 13:13:52 UTC
Ryan is working on something slightly different which may negate the need for this patch
Comment 3 Tomeu Vizoso 2010-09-08 09:10:59 UTC
Created attachment 169743 [details] [review]
Add override for GLib.Variant.new_tuple

* gi/gimodule.c: Add _wrap_pyg_variant_new_tuple
* gi/overrides/GLib.py: Override Variant.new_tuple and Variant.get_string
* gi/pygi-type.[hc]: split _pygi_type_import_by_name out from
  _pygi_type_import_by_gi_info
* gi/types.py: Never override gobject.TYPE_NONE
* tests/test_everything.py: Add tests for GVariant tuples
Comment 4 Tomeu Vizoso 2010-09-08 09:11:59 UTC
Rebased, I think we shouldn't wait any more. This patch will allow making calls with GDBus.
Comment 5 Gabor Kelemen 2010-09-09 20:12:57 UTC
Hi, could you check in the gi/overrides/GLib.py file too? It breaks the build:

$ ls gi/overrides/G*
gi/overrides/Gdk.py  gi/overrides/GIMarshallingTests.py  gi/overrides/Gtk.py

make[3]: Entering directory `/home/gabor/checkout/gnome/pygobject/gi/overrides'
make[3]: Nothing to be done for `install-exec-am'.
make[3]: *** No rule to make target `GLib.py', needed by `install-pygioverridesPYTHON'.  Stop.
make[3]: Leaving directory `/home/gabor/checkout/gnome/pygobject/gi/overrides'
Comment 6 Tomeu Vizoso 2010-09-10 08:55:01 UTC
(In reply to comment #5)
> Hi, could you check in the gi/overrides/GLib.py file too? It breaks the build:

Sorry, it should be fine now.