After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 624952 - patch for --as-needed and binutils-gold support
patch for --as-needed and binutils-gold support
Status: RESOLVED DUPLICATE of bug 624601
Product: gedit
Classification: Applications
Component: general
unspecified
Other Linux
: Normal normal
: ---
Assigned To: Gedit maintainers
Gedit maintainers
Depends on:
Blocks:
 
 
Reported: 2010-07-21 17:14 UTC by Rob Savoye
Modified: 2011-01-15 14:20 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch that fixes linking (561 bytes, patch)
2010-07-21 17:14 UTC, Rob Savoye 		none Details | Review

Description Rob Savoye 2010-07-21 17:14:21 UTC 
Created attachment 166310 [details] [review]
patch that fixes linking

When using --as-needed and binutils-gold, the libICE library must be added to
the link. This patch adds -lICE to $LIBS if it exists.
Comment 1 André Klapper 2010-08-02 23:08:51 UTC 
That patch looks... weird.
Was this created by "git format-patch"?
Comment 2 Rob Savoye 2010-08-02 23:13:10 UTC 
No, it was from "bzr diff". How weird can a diff be ? :-) It's a pretty small change, should be easy to apply even by hand. Oh, I just checked the URL, and see what you mean. Not sure how all the escape codes got into the patch. I'll be more care. The patch is simply:

dnl When linking with --as-needed, add -lICE to LIBS.
AC_CHECK_LIB(ICE, IceRelease,,)
Comment 3 Paolo Borelli 2010-08-03 06:59:07 UTC 
This looks like a duplicate of bug #624601 even if the proposed solution is slightly different
Comment 4 Rob Savoye 2010-08-07 03:29:16 UTC 
The fix in bug #624601 accomplishes the same thing in a somewhat cleaner fashion.
Comment 5 Paolo Borelli 2011-01-15 14:20:40 UTC 
marking as dupe then...

*** This bug has been marked as a duplicate of bug 624601 ***