GNOME Bugzilla – Bug 624952
patch for --as-needed and binutils-gold support
Last modified: 2011-01-15 14:20:40 UTC
Created attachment 166310 [details] [review]
patch that fixes linking
When using --as-needed and binutils-gold, the libICE library must be added to
the link. This patch adds -lICE to $LIBS if it exists.
That patch looks... weird.
Was this created by "git format-patch"?
No, it was from "bzr diff". How weird can a diff be ? :-) It's a pretty small change, should be easy to apply even by hand. Oh, I just checked the URL, and see what you mean. Not sure how all the escape codes got into the patch. I'll be more care. The patch is simply:
dnl When linking with --as-needed, add -lICE to LIBS.
This looks like a duplicate of bug #624601 even if the proposed solution is slightly different
The fix in bug #624601 accomplishes the same thing in a somewhat cleaner fashion.
marking as dupe then...
*** This bug has been marked as a duplicate of bug 624601 ***