After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 624948 - patch for --as-needed and binutils-gold support
patch for --as-needed and binutils-gold support
Product: evince
Classification: Core
Component: general
Other Linux
: Normal normal
: ---
Assigned To: Evince Maintainers
Evince Maintainers
Depends on:
Reported: 2010-07-21 16:51 UTC by Rob Savoye
Modified: 2014-05-04 04:05 UTC
See Also:
GNOME target: ---
GNOME version: ---

patch that fixes linking (611 bytes, patch)
2010-07-21 16:51 UTC, Rob Savoye
reviewed Details | Review

Description Rob Savoye 2010-07-21 16:51:52 UTC
Created attachment 166308 [details] [review]
patch that fixes linking

When using --as-needed and binutils-gold, the libICE library must be added to the link. This patch adds -lICE to $LIBS if it exists.
Comment 1 Germán Poo-Caamaño 2014-05-03 18:15:19 UTC
Revisiting old bugs with patches.

Can you still reproduce this issue?

I tried using binutils-gold and added '-Xlinker --as-needed' to
LD_FLAGS, but still I could build evince successfully.
Comment 2 Germán Poo-Caamaño 2014-05-03 18:17:38 UTC
Comment on attachment 166308 [details] [review]
patch that fixes linking

FWIW, the patch contains garbage (ansi codes for color in a terminal)
Comment 3 Rob Savoye 2014-05-04 03:48:55 UTC
This patch is pretty ancient, but also pretty simple. I don't have my original sources around anymore, sorry. I'd assume by now this problem has fixed since most distros use --as-needed. This was probably only a problem while that transition was being made.
Comment 4 Germán Poo-Caamaño 2014-05-04 04:05:46 UTC
Thanks for the feedback. I am closing this as obsolete. However, feel
free to re-open it if the problem appaears again in the future.