After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 624905 - [videomixer] Add support for forwarding QoS events upstream
[videomixer] Add support for forwarding QoS events upstream
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-base
git master
Other Linux
: Normal normal
: 0.10.26
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 626048
Blocks:
 
 
Reported: 2010-07-21 08:22 UTC by Sebastian Dröge (slomo)
Modified: 2010-09-04 13:08 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
videomixer: Add support for forwarding QoS events upstream (4.00 KB, patch)
2010-07-21 08:23 UTC, Sebastian Dröge (slomo)
rejected Details | Review
videomixer: Move debug categories into the source files and add debug category for the blend functions (2.09 KB, patch)
2010-07-27 14:36 UTC, Sebastian Dröge (slomo)
committed Details | Review
videomixer2: Implement videomixer2 (133.90 KB, patch)
2010-07-27 14:36 UTC, Sebastian Dröge (slomo)
none Details | Review

Description Sebastian Dröge (slomo) 2010-07-21 08:22:37 UTC
Attached patch adds support for forwarding QoS events upstream in videomixer.

This is done by calculating the running time difference between the different streams and adjusting the timestamps in the QoS events.
Comment 1 Sebastian Dröge (slomo) 2010-07-21 08:23:55 UTC
Created attachment 166259 [details] [review]
videomixer: Add support for forwarding QoS events upstream

Fixes bug #624905.
Comment 2 Sebastian Dröge (slomo) 2010-07-21 10:19:55 UTC
Of course this introduces synchronizations problems between streams if only one stream drops frames... and it causes problems if the streams are running with different rates (but that was broken before already).

This is caused by videomixer's ignorance of timestamps... to fix this videomixer should mix the streams synchronized by the running time.
Comment 3 Sebastian Dröge (slomo) 2010-07-27 14:36:21 UTC
Created attachment 166649 [details] [review]
videomixer: Move debug categories into the source files and add debug category for the blend functions
Comment 4 Sebastian Dröge (slomo) 2010-07-27 14:36:26 UTC
Created attachment 166650 [details] [review]
videomixer2: Implement videomixer2

This is based on collectpads2 and synchronizing all
streams based on the running time.
Comment 5 Sebastian Dröge (slomo) 2010-09-04 13:08:05 UTC
commit bcfd60a8d200e3f18d6260e1a6d71835d76036fb
Author: Sebastian Dröge <sebastian.droege@collabora.co.uk>
Date:   Mon Jul 26 16:07:15 2010 +0200

    videomixer2: Add videomixer2 element
    
    This is based on collectpads2 and is synchronizing
    all streams based on the running time.
    
    New features compared to old videomixer:
     * Synchronizing frames on the running time
     * Improved and simplified negotiation
     * Full QoS support
     * Variable framerate support
    
    Fixes bug #626048, #624905.