GNOME Bugzilla – Bug 624824
GIMP should use gtk-image-menu-item-set-always-show-image on some menu items
Last modified: 2011-04-02 13:40:39 UTC
In Ubuntu benste reported: IN previous version, and the windows version had small icons indicating the function as in the main tools window. Having a list with the same functions it's very confusing to see about 20 entrys withouht icons. Launchpad ref: https://bugs.edge.launchpad.net/ubuntu/+source/gimp/+bug/599079 Thanks!
That's a global setting of your desktop. It applies to all GTK+ applications and you can change this system-wide.
(In reply to comment #1) > That's a global setting of your desktop. It applies to all GTK+ applications > and you can change this system-wide. But Gnome has decided to remove the icons for menu items by *default* [ Bug 557469 ] and the option to revert is hidden in the gconf settings. *Not* my change of choice but that is what gnome has decided to do. Gimp needs use gtk-image-menu-item-set-always-show-image [0] option for atleast a few of the items like: Edit > Fill with FG color Fill with BG color Fill with pattern Image > Transform > Flip Horizontally Flip Vertically Rotate 90 clockwise Rotate 90 counter-clockwise Layer > Transform > Flip Horizontally Flip Vertically Rotate 90 clockwise Rotate 90 counter-clockwise We need to force icons by default atleast for the fill and rotate actions. This makes it easy to identify the options , its more easier than a user having to dig into the gconf. Subscribing Andreas Nilsson to the bug as he has been more involved with the change in gnome[1]. I'm kinda surprised he hadnt filed a bug in GIMP yet. ;) Nor did anyone file a bug in GIMP about this for so long, which seems like most of the GIMP users probably reverted the change! This change was also mentioned in the desktop devel list.[2] 0. http://library.gnome.org/devel/gtk/2.17/GtkImageMenuItem.html#gtk-image-menu-item-set-always-show-image 1. http://www.andreasn.se/blog/?p=103 (syndicated on Planet GNOME) 2. http://mail.gnome.org/archives/desktop-devel-list/2009-July/msg00126.html
I see the point for the fill menu items because they actually show small previews, not icons. But the transform menu items are in no way different from other menu items.
The blog article mentions the exceptions: "What are the exceptions? A menu item shall have a icon if it represents a dynamic object such as a: * Application * File or bookmark * Device " So according to that, none of the transforms menu items would qualify.
(In reply to comment #3) > I see the point for the fill menu items because they actually show > small previews, not icons. But the transform menu items are in no > way different from other menu items. Personally , I turn on the icons[since the menu structure in several applications need improvement first]. But following discussion in Bug 588668 and from lp reports of users not being able to easily understand which direction the rotate is , it would be better to have icons for the Rotate icons. so i just added the flip ones. ;) Maybe the 3 rotate icons alone are in need of icons, Andreas ?
The rotate icons are probably a good exception to the rule. +1
Reopening, changing summary and setting on the 2.8 milestone...
This is not a regression from 2.6 and a 2.8 release is long overdue, removing from 2.8 milestone
Fixed in master: commit 61025c6023653bc2b42746b73e6468f0a47ede60 Author: Michael Natterer <mitch@gimp.org> Date: Sat Apr 2 15:38:55 2011 +0200 Bug 624824 - use gtk-image-menu-item-set-always-show-image on some menu items Always show icons for: - Fill FG/BG/Pattern - Rotate - Recently opened - Open images app/actions/drawable-actions.c | 9 +++++++++ app/actions/edit-actions.c | 9 +++++++++ app/actions/file-actions.c | 2 ++ app/actions/image-actions.c | 9 +++++++++ app/actions/windows-actions.c | 3 +++ app/widgets/gimpactiongroup.c | 23 +++++++++++++++++++++++ app/widgets/gimpactiongroup.h | 3 +++ 7 files changed, 58 insertions(+), 0 deletions(-)