After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 624779 - GtkCalendar padding/margin/spacing/border/whatever is too hard-coded
GtkCalendar padding/margin/spacing/border/whatever is too hard-coded
Product: gtk+
Classification: Platform
Component: Widget: Other
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
Depends on:
Reported: 2010-07-19 23:20 UTC by Cody Russell
Modified: 2010-08-03 19:53 UTC
See Also:
GNOME target: ---
GNOME version: ---

Convert INNER_BORDER, CALENDAR_XSEP, CALENDAR_YSEP to style properties. (15.91 KB, patch)
2010-07-19 23:20 UTC, Cody Russell
committed Details | Review

Description Cody Russell 2010-07-19 23:20:17 UTC
Created attachment 166185 [details] [review]

GtkCalendar has some constants defined that affect the size/layout of it, and it seems like it would be nice to move those to be style properties.

In particular the one I care about is INNER_BORDER (I feel like it's too big and clunky looking now, and changing to 0 makes it feel tighter to me), but while I'm at it I figure we might as well convert the others to style properties as well.

I'm attaching a patch that turns INNER_BORDER, CALENDAR_XSEP, and CALENDAR_YSEP into style properties.  There are three constants that I didn't convert yet, as I'd like some feedback: CALENDAR_MARGIN, DAY_XSEP, DAY_YSEP.  All three are #defined as 0, and DAY_XSEP/DAY_YSEP both have a comment saying how they're not really useful for a small calendar.

So I wonder if these should be converted to style properties as well, or if they should be left alone, or if they're really useless then maybe they should just be removed to clean up the code a bit.  I'm willing to do any of these options while I'm looking at this.
Comment 1 Cody Russell 2010-08-03 19:53:44 UTC
Committed to git master and gtk-2-22 branch.