After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 624770 - rtspsrc: memory leak in gst_rtspsrc_handle_request
rtspsrc: memory leak in gst_rtspsrc_handle_request
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins-good
0.10.24
Other Linux
: Normal normal
: 0.10.25
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2010-07-19 21:04 UTC by American Dynamics
Modified: 2010-08-14 13:09 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (338 bytes, patch)
2010-07-19 21:04 UTC, American Dynamics 		none Details | Review

Description American Dynamics 2010-07-19 21:04:26 UTC 
Created attachment 166177 [details] [review]
patch

Memory leak occurs in gst_rtspsrc_handle_request function in gstrtspsrc.c.

The RTSP server rtspsrc is communicating with sends a GET_PARAMETER request periodically as a ping.  The code in gst_rtspsrc_handle_request forms an OK response and sends, but doesn't call gst_rtsp_message_unset to free the memory after sending the response.  This results in a constant slow memory leak.

Examined git; leak still seems to exist in most current code.  Patch attached.
Comment 1 Wim Taymans 2010-07-26 14:09:48 UTC 
Please provide a real name (so that we can properly credit your work) for future (bigger) patches. Thanks! 

commit 8696d10a5befc5bf67abd0f26576c080dc99f851
Author: Wim Taymans <wim.taymans@collabora.co.uk>
Date:   Mon Jul 26 15:31:16 2010 +0200

    rtspsrc: fix memory leak in server request reply
    
    The RTSP server rtspsrc is communicating with, sends a GET_PARAMETER request
    periodically as a ping.  The code in gst_rtspsrc_handle_request forms an OK
    response and sends, but doesn't call gst_rtsp_message_unset to free the memory
    after sending the response.  This results in a constant slow memory leak.
    
    Fixes #624770
Comment 2 American Dynamics 2010-08-09 18:09:13 UTC 
the developer's name is Jonathan Short