After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 624737 - Please fix POTFILES.in
Please fix POTFILES.in
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: .General
2.90.x
Other All
: Normal trivial
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2010-07-19 14:01 UTC by Gabor Kelemen
Modified: 2010-08-02 22:46 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
fix POTFILES.in (1.09 KB, patch)
2010-07-19 14:30 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Gabor Kelemen 2010-07-19 14:01:01 UTC 
http://l10n.gnome.org/module/gtk+/ says:

warn  	There are some missing files from POTFILES.in:

    * gdk/gdkdevice.c
    * gdk/gdkdevicemanager.c
    * gdk/x11/gdkdevice-xi.c
    * gdk/x11/gdkdevice-xi2.c
    * gdk/x11/gdkdevicemanager-xi.c
    * gtk/gtksizerequest.c
Comment 1 Javier Jardón (IRC: jjardon) 2010-07-19 14:30:24 UTC 
Created attachment 166161 [details] [review]
fix POTFILES.in
Comment 2 André Klapper 2010-07-19 19:19:37 UTC 
Comment on attachment 166161 [details] [review]
fix POTFILES.in

Javier: Please commit (and notify gnome-i18n@).
Comment 3 Gabor Kelemen 2010-07-19 19:25:39 UTC 
I thought it is unnecessary to mention, but if you add a file to the POTFILES.in file of the po directory, you should add them to the POTFILES.skip file of the po-properties directory (and vice-versa). So please do not forget about that either.
Comment 4 Matthias Clasen 2010-08-02 18:18:50 UTC 
(In reply to comment #3)
> I thought it is unnecessary to mention, but if you add a file to the
> POTFILES.in file of the po directory, you should add them to the POTFILES.skip
> file of the po-properties directory (and vice-versa). So please do not forget
> about that either.

No, po/ and po-properties/ are not mutually exclusive (not per file, anyway)
Comment 5 Javier Jardón (IRC: jjardon) 2010-08-02 22:46:30 UTC 
Comment on attachment 166161 [details] [review]
fix POTFILES.in

commit 57550e1b473be7e8e74e68fefff36c55d1661cdc

Sorry for the delay, I can't pull the gtk+ repo because a bug in git (bug #625135)
Comment 6 Javier Jardón (IRC: jjardon) 2010-08-02 22:46:39 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.