After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 624650 - no more GtkNotebookPage in GTK+ 3.0
no more GtkNotebookPage in GTK+ 3.0
Status: RESOLVED FIXED
Product: empathy
Classification: Core
Component: Chat
unspecified
Other Linux
: Normal normal
: ---
Assigned To: empathy-maint
Depends on:
Blocks: 624653
 
 
Reported: 2010-07-18 08:20 UTC by Craig Keogh
Modified: 2010-07-19 09:57 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Craig Keogh 2010-07-18 08:20:00 UTC
GtkNotebookPage was removed in GTK+ 3.0, see:
bug 618327
http://git.gnome.org/browse/gtk+/commit/?id=04c54efe5cf13cccf9897c4b5d9bf9d364d1e078
http://git.gnome.org/browse/gtk+/commit/?id=828f5cbe2e04b60ec013df6fc33f7a5b537e6efd

Building empathy git master via JHBuild on Fedora 13 fails with:

/bin/sh ../libtool  --tag=CC   --mode=link gcc  -O0 -g -lm -L/usr/lib64/nvidia -o libempathy-accounts-common.la  empathy-accounts-common.lo empathy-account-assistant.lo empathy-accounts-dialog.lo empathy-auto-salut-account-helper.lo empathy-import-dialog.lo empathy-import-pidgin.lo empathy-import-widget.lo empathy-import-utils.lo ../libempathy-gtk/libempathy-gtk.la -Wl,--export-dynamic -pthread -L/opt/gnome2/lib64 -lnotify -ldbus-glib-1 -lgmodule-2.0 -ldbus-1 -lpthread -lgobject-2.0 -lgthread-2.0 -lrt -lglib-2.0   -pthread -L/opt/gnome2/lib64 -lunique-3.0 -lgtk-x11-3.0 -lgdk-x11-3.0 -latk-1.0 -lgio-2.0 -lpangoft2-1.0 -lpangocairo-1.0 -lgdk_pixbuf-2.0 -lm -lcairo -lpango-1.0 -lfreetype -lfontconfig -lgobject-2.0 -lgmodule-2.0 -lgthread-2.0 -lrt -lglib-2.0   -pthread -L/opt/gnome2/lib64 -lgstfarsight-0.10 -lgstbase-0.10 -lgnome-keyring -lgstinterfaces-0.10 -lgstreamer-0.10 -lebook-1.2 -lcamel-1.2 -ldbus-glib-1 -ledataserver-1.2 -lsqlite3 -lssl3 -lsmime3 -lnss3 -lnssutil3 -lplds4 -lplc4 -lnspr4 -ldl -lgconf-2 -lsoup-2.4 -lgio-2.0 -lgmodule-2.0 -ldbus-1 -lpthread -lgobject-2.0 -lgthread-2.0 -lrt -lglib-2.0 -ltelepathy-farsight -ltelepathy-logger -ltelepathy-glib -lxml2 -lX11    -pthread -L/opt/gnome2/lib64 -lwebkitgtk-3.0 -lgtk-x11-3.0 -lsoup-2.4 -lgdk-x11-3.0 -latk-1.0 -lpangoft2-1.0 -lpangocairo-1.0 -lgdk_pixbuf-2.0 -lm -lcairo -lpango-1.0 -lfreetype -lfontconfig -lgio-2.0 -lgobject-2.0 -lgmodule-2.0 -lgthread-2.0 -lrt -lglib-2.0    
libtool: link: rm -fr  .libs/libempathy-accounts-common.a .libs/libempathy-accounts-common.la
libtool: link: (cd .libs/libempathy-accounts-common.lax/libempathy-gtk.a && ar x "/home/oxyde/gnome2/empathy/src/../libempathy-gtk/.libs/libempathy-gtk.a")
empathy-chat-window.c:1464: error: expected declaration specifiers or ‘...’ before ‘GtkNotebookPage’
make[3]: *** [empathy-chat-window.o] Error 1
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2
Comment 1 Frederic Peters 2010-07-18 09:16:55 UTC
FWIW this is already fixed in this branch: http://git.collabora.co.uk/?p=user/danni/empathy.git;a=commitdiff;h=d4ae4c6dbb725b3ac4458e895baa1fa552ac450f
Comment 2 Xavier Claessens 2010-07-18 12:42:49 UTC
Guillaume is on vacation, but +1 from me for that patch.
Comment 3 Danielle Madeley 2010-07-19 09:57:47 UTC
Cherry-picked.