After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 624531 - Banshee media player can not work normally in Netherlands (NL) language in MeeGo
Banshee media player can not work normally in Netherlands (NL) language in MeeGo
Status: RESOLVED FIXED
Product: banshee
Classification: Other
Component: Importing
1.6.1
Other Linux
: Normal normal
: 1.x
Assigned To: Banshee Maintainers
Banshee Maintainers
: 624583 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2010-07-16 10:45 UTC by Max Lin
Modified: 2010-07-18 03:36 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Untested patch using SQL parameters (2.34 KB, patch)
2010-07-17 22:48 UTC, Aaron Bockover
none Details | Review

Description Max Lin 2010-07-16 10:45:16 UTC
BUG DETAILED DESCRIPTIONS
===========================================================
Banshee media player can not work normally in Nederland (NL) language, when 
install meego image choose default language is Nederland. If default language
is Nederland, after launch Banshee, when click lift list item or after import data
will auto close or crash.

EXACT STEPS LEADING TO PROBLEM:
(Explain in detail what you do (e.g. tap on OK) and what you see (e.g. message
Connection Failed appears))
===========================================================
1. Dash Nederlands (NL) image from server and go through OOBE.
2. Go to Task item panel \ Media to launch Banshee media player.
3. Click any item on the left list panel or import data of Banshee.
4. Will auto close or crash.

P.S. Nederland Videos is call the Video's, may be the Video" ' "s caused the exception.
Comment 1 Alexander Kojevnikov 2010-07-17 01:14:16 UTC
*** Bug 624583 has been marked as a duplicate of this bug. ***
Comment 2 jlee 2010-07-17 21:13:20 UTC
Max found the following SQL exception in log:

[2 Debug 10:33:37.337] Exception executing command: BEGIN;
                    DELETE FROM CorePlaylistEntries WHERE TrackID IN (SELECT
TrackID FROM CoreTracks WHERE PrimarySourceID = 2 AND Uri LIKE
'file:///home/linux/Video's/%' AND LastSyncedStamp IS NOT NULL AND
LastSyncedStamp < 1279294417);
                    DELETE FROM CoreSmartPlaylistEntries WHERE TrackID IN
(SELECT TrackID FROM CoreTracks WHERE PrimarySourceID = 2 AND Uri LIKE
'file:///home/linux/Video's/%' AND LastSyncedStamp IS NOT NULL AND
LastSyncedStamp < 1279294417);

The Nl use "Video's" is video folder name it need add escape char.  

The problem there need a escape char in Video's like Video\'s, when source code
new a SaftUri, need take care this:

            // Delete tracks that are under the BaseDirectory and that weren't
rescanned just now
            string condition = String.Format (
                "WHERE PrimarySourceID = ? AND Uri LIKE '{0}%' AND
LastSyncedStamp IS NOT NULL AND LastSyncedStamp < ?",
                new SafeUri (psource.BaseDirectoryWithSeparator).AbsoluteUri
            );
Comment 3 Aaron Bockover 2010-07-17 22:48:36 UTC
Created attachment 166100 [details] [review]
Untested patch using SQL parameters

This is a completely untested patch. Gabriel, it seems you were using proper SQL parameters for some parts of the condition, so I'm not sure why you didn't do this for the Uri column. Would you please review and test this patch?
Comment 4 Gabriel Burt 2010-07-18 02:15:09 UTC
I pushed a slightly different version (adding StringUtil.EscapeLike for URIs that might contain % or _), thanks Aaron.  Also pushed to stable-1.6.
Comment 5 Aaron Bockover 2010-07-18 03:36:30 UTC
muchas gracias, señor