After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 624397 - Move GtkBoxChild from public .h to gtkbox.c
Move GtkBoxChild from public .h to gtkbox.c
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.90.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2010-07-14 23:00 UTC by Javier Jardón (IRC: jjardon)
Modified: 2010-07-20 01:04 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Do not use GtkBoxChild in GtkStatusBar (1.72 KB, patch)
2010-07-14 23:03 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review
Move GtkBoxChild from public .h to gtkbox.c (3.62 KB, patch)
2010-07-14 23:04 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Javier Jardón (IRC: jjardon) 2010-07-14 23:00:42 UTC 
Patches following
Comment 1 Javier Jardón (IRC: jjardon) 2010-07-14 23:03:58 UTC 
Created attachment 165927 [details] [review]
Do not use GtkBoxChild in GtkStatusBar
Comment 2 Javier Jardón (IRC: jjardon) 2010-07-14 23:04:37 UTC 
Created attachment 165928 [details] [review]
Move GtkBoxChild from public .h to gtkbox.c
Comment 3 Matthias Clasen 2010-07-15 20:31:06 UTC 
Comment on attachment 165927 [details] [review]
Do not use GtkBoxChild in GtkStatusBar

The previous code here was just bogus, expecting gtk_container_get_children to return GtkBoxChild structs.

I assume you have tested this one ?
Comment 4 Javier Jardón (IRC: jjardon) 2010-07-20 01:03:12 UTC 
Comment on attachment 165927 [details] [review]
Do not use GtkBoxChild in GtkStatusBar

yeah, tested here.

commit 6852137e13545d10df1c9e512ba717668f82e583
Comment 5 Javier Jardón (IRC: jjardon) 2010-07-20 01:03:51 UTC 
Comment on attachment 165927 [details] [review]
Do not use GtkBoxChild in GtkStatusBar

Sorry, the correct commit is 82efd2d92f775a60639a4b404b66a4096acbcd12
Comment 6 Javier Jardón (IRC: jjardon) 2010-07-20 01:04:07 UTC 
Comment on attachment 165928 [details] [review]
Move GtkBoxChild from public .h to gtkbox.c

commit 6852137e13545d10df1c9e512ba717668f82e583
Comment 7 Javier Jardón (IRC: jjardon) 2010-07-20 01:04:25 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.