After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 624333 - Deprecate GtkRecentManager:limit
Deprecate GtkRecentManager:limit
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Class: GtkRecent
2.21.x
Other All
: Normal normal
: ---
Assigned To: gtk-bugs
Emmanuele Bassi (:ebassi)
deprecations
Depends on:
Blocks:
 
 
Reported: 2010-07-14 11:44 UTC by Emmanuele Bassi (:ebassi)
Modified: 2011-02-04 16:12 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Deprecate GtkRecentManager:limit (2.82 KB, patch)
2010-07-14 15:37 UTC, Javier Jardón (IRC: jjardon) 		committed Details | Review

Description Emmanuele Bassi (:ebassi) 2010-07-14 11:44:53 UTC 
the :limit property of GtkRecentManager does not serve any useful purpose: the length of the list should be managed by the view (implementing GtkRecentChooser), and not by the model (the recent manager).

ideally, the :limit property should just be deprecated and have no effect in gtk-2-22, and be removed in 2.90.
Comment 1 Javier Jardón (IRC: jjardon) 2010-07-14 15:37:13 UTC 
Created attachment 165886 [details] [review]
Deprecate GtkRecentManager:limit
Comment 2 Emmanuele Bassi (:ebassi) 2010-07-14 23:34:55 UTC 
Review of attachment 165886 [details] [review]:

wow, that was fast - I branched off to do this myself :-)

looks good, except for a minor nag. feel free to commit.

::: gtk/gtkrecentmanager.c
@@ +659,3 @@
+ *   length of the list should be managed by the view (implementing
+ * Deprecated: 2.22: #GtkRecenManager::limit property is deprecated. The
+ *

it should also say: "setting this property does not have any effect". and the notation for properties is #ObjectClass:property.
Comment 3 Javier Jardón (IRC: jjardon) 2010-07-15 00:52:06 UTC 
Comment on attachment 165886 [details] [review]
Deprecate GtkRecentManager:limit

committed with you comments:

master 678e738f8dce754ae4b415dfb7ec70abc38e0083
commit 838dfd50acc70c233882cf1af9bc69401b51752c
Comment 4 Javier Jardón (IRC: jjardon) 2010-07-15 01:26:22 UTC 
Property removed in master

commit cfa241a8912b9a5c483b3cf0c6e11d6722651b3c
Comment 5 Javier Jardón (IRC: jjardon) 2010-07-15 01:26:30 UTC 
This problem has been fixed in the development version. The fix will be available in the next major software release. Thank you for your bug report.
Comment 6 André Klapper 2010-07-15 08:15:02 UTC 
678e738f8dce754ae4b415dfb7ec70abc38e0083 says "GtkRecenManager" (missing a "t") into two places.
Comment 7 Emmanuele Bassi (:ebassi) 2010-07-15 08:57:24 UTC 
typo fixed in gtk-2-22